linux-kernel - Re: [PATCH 1/2] perf x86/topdown: Make topdown metrics comparators be symmetric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172918315983.639809.13756139511632758353.b4-ty@kernel.org>
Date: Thu, 17 Oct 2024 09:39:19 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, Ian Rogers <irogers@...gle.com>, 
 Adrian Hunter <adrian.hunter@...el.com>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Kan Liang <kan.liang@...ux.intel.com>, 
 Dapeng Mi <dapeng1.mi@...ux.intel.com>
Cc: linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Dapeng Mi <dapeng1.mi@...el.com>
Subject: Re: [PATCH 1/2] perf x86/topdown: Make topdown metrics comparators
 be symmetric

On Fri, 11 Oct 2024 11:02:06 +0000, Dapeng Mi wrote:

> The commit "3b5edc0421e2 (perf x86/topdown: Don't move topdown metric
>  events in group)" modifies topdown metrics comparator to move topdown
> metrics events which are not in same group with previous event. But it
> just modifies the 2nd comparator and causes the comparators become
> asymmetric.
> 
> Thus modify the 1st topdown metrics comparator and make the two
> comparators be symmetric, and refine the comments as well.
> 
> [...]

Applied to perf-tools-next, thanks!

Best regards,
Namhyung