linux-kernel - 回复: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID:
 <ZQ0PR01MB1302A45C24808A6067928BB8F2472@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn>
Date: Thu, 17 Oct 2024 01:17:36 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>
CC: Conor Dooley <conor.dooley@...rochip.com>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>, Aurelien Jarno <aurelien@...el32.net>, Emil Renner
 Berthing <kernel@...il.dk>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject:
 回复: [PATCH v1] riscv: dts: starfive: disable unused csi/camss nodes

Hi, Conor

Thanks for your patch.

> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> Aurelien reported probe failures due to the csi node being enabled without
> having a camera attached to it. A camera was in the initial submissions, but
> was removed from the dts, as it had not actually been present on the board,
> but was from an addon board used by the developer of the relevant drivers.
> The non-camera pipeline nodes were not disabled when this happened and
> the probe failures are problematic for Debian. Disable them.
> 
> CC: stable@...r.kernel.org
> Fixes: 28ecaaa5af192 ("riscv: dts: starfive: jh7110: Add camera subsystem
> nodes")

Here you write it in 13 characters, should be "Fixes: 28ecaaa5af19 ..." 

Best Regards
Changhuang.

> Closes: https://lore.kernel.org/all/Zw1-vcN4CoVkfLjU@aurel32.net/
> Reported-by: Aurelien Jarno <aurelien@...el32.net>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> CC: Emil Renner Berthing <kernel@...il.dk>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Changhuang Liang <changhuang.liang@...rfivetech.com>
> CC: devicetree@...r.kernel.org
> CC: linux-riscv@...ts.infradead.org
> CC: linux-kernel@...r.kernel.org
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index c7771b3b64758..d6c55f1cc96a9 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -128,7 +128,6 @@ &camss {
>  	assigned-clocks = <&ispcrg JH7110_ISPCLK_DOM4_APB_FUNC>,
>  			  <&ispcrg JH7110_ISPCLK_MIPI_RX0_PXL>;
>  	assigned-clock-rates = <49500000>, <198000000>;
> -	status = "okay";
> 
>  	ports {
>  		#address-cells = <1>;
> @@ -151,7 +150,6 @@ camss_from_csi2rx: endpoint {  &csi2rx {
>  	assigned-clocks = <&ispcrg JH7110_ISPCLK_VIN_SYS>;
>  	assigned-clock-rates = <297000000>;
> -	status = "okay";
> 
>  	ports {
>  		#address-cells = <1>;
> --
> 2.45.2