linux-kernel - Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202410180045.uBklh7FI-lkp@intel.com>
Date: Fri, 18 Oct 2024 00:46:36 +0800
From: kernel test robot <lkp@...el.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>, maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
	simona@...ll.ch, christian.koenig@....com, ray.huang@....com,
	dmitry.baryshkov@...aro.org, dave.stevenson@...pberrypi.com,
	mcanal@...lia.com, quic_jjohnson@...cinc.com,
	karolina.stolarek@...el.com, Arunpravin.PaneerSelvam@....com,
	thomas.hellstrom@...ux.intel.com, asomalap@....com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, ruanjinjie@...wei.com
Subject: Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in
 drm_display_mode_from_cea_vic()

Hi Jinjie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.12-rc3 next-20241017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/drm-connector-hdmi-Fix-memory-leak-in-drm_display_mode_from_cea_vic/20241014-152022
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20241014071632.989108-2-ruanjinjie%40huawei.com
patch subject: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()
config: x86_64-randconfig-121-20241017 (https://download.01.org/0day-ci/archive/20241018/202410180045.uBklh7FI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410180045.uBklh7FI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410180045.uBklh7FI-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/tests/drm_connector_test.c:1008:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1008:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1008:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: sparse:     got struct drm_display_mode const *[assigned] mode

vim +1008 drivers/gpu/drm/tests/drm_connector_test.c

   987	
   988	/*
   989	 * Test that for a given mode, with 8bpc and an RGB output the TMDS
   990	 * character rate is equal to the mode pixel clock.
   991	 */
   992	static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
   993	{
   994		struct drm_connector_init_priv *priv = test->priv;
   995		const struct drm_display_mode *mode;
   996		unsigned long long rate;
   997		struct drm_device *drm = &priv->drm;
   998	
   999		mode = drm_display_mode_from_cea_vic(drm, 16);
  1000		KUNIT_ASSERT_NOT_NULL(test, mode);
  1001	
  1002		KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK);
  1003	
  1004		rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
  1005		KUNIT_ASSERT_GT(test, rate, 0);
  1006		KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
  1007	
> 1008		drm_mode_destroy(drm, mode);
  1009	}
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki