linux-kernel - Re: [PATCH v3 0/8] CSV/JSON metric thresholds, fix printf modifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxFBdCMFZ50oo-s2@google.com>
Date: Thu, 17 Oct 2024 09:55:16 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	John Garry <john.g.garry@...cle.com>, Will Deacon <will@...nel.org>,
	James Clark <james.clark@...aro.org>,
	Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...ux.dev>,
	Yicong Yang <yangyicong@...ilicon.com>,
	Weilin Wang <weilin.wang@...el.com>,
	Tim Chen <tim.c.chen@...ux.intel.com>,
	Thomas Richter <tmricht@...ux.ibm.com>,
	Sumanth Korikkar <sumanthk@...ux.ibm.com>,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/8] CSV/JSON metric thresholds, fix printf modifiers

On Thu, Oct 17, 2024 at 09:44:08AM -0700, Ian Rogers wrote:
> On Thu, Oct 17, 2024 at 9:39 AM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > On Wed, 16 Oct 2024 10:53:42 -0700, Ian Rogers wrote:
> >
> > > Metric thresholds are being computed for CSV and JSON output but not
> > > displayed. Rename the color that encodes the threshold as enum values
> > > and use to generate string constants in a CSV column or json
> > > dictionary value.
> > >
> > > Add printf attribute to functions in color.h that could support
> > > it. Fix bad printf format strings that this detected.
> > >
> > > [...]
> >
> > Applied to perf-tools-next, thanks!
> 
> Sorry for the trouble, could we switch to the v4 series due to issues
> on hypervisors with not counted events in CSV output missing a column:
> https://lore.kernel.org/lkml/20241016215139.212939-1-irogers@google.com/
> The patch set drops the CSV output metric threshold support.

Oops, sorry for missing v4.  And I also noticed a build error on i386.
I'll drop this for now and push perf-tools-next soon.

Thanks,
Namhyung