linux-kernel - Re: [PATCH v9 2/7] iommu/riscv: Add RISC-V IOMMU platform device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2o1u4BYyHhi3dVcBrB8T2JpXdxStsfYodmOT-6a8KMHAot8w@mail.gmail.com>
Date: Thu, 17 Oct 2024 09:45:14 -0700
From: Tomasz Jeznach <tjeznach@...osinc.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, 
	Robin Murphy <robin.murphy@....com>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Anup Patel <apatel@...tanamicro.com>, Sunil V L <sunilvl@...tanamicro.com>, 
	Nick Kossifidis <mick@....forth.gr>, Sebastien Boeuf <seb@...osinc.com>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	iommu@...ts.linux.dev, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux@...osinc.com, 
	Lu Baolu <baolu.lu@...ux.intel.com>
Subject: Re: [PATCH v9 2/7] iommu/riscv: Add RISC-V IOMMU platform device driver

Hello Uwe,

On Wed, Oct 16, 2024 at 2:35 AM Uwe Kleine-König
<u.kleine-koenig@...libre.com> wrote:
>
> Hello,
>
> On Thu, Oct 10, 2024 at 12:48:05PM -0700, Tomasz Jeznach wrote:
> > +static const struct of_device_id riscv_iommu_of_match[] = {
> > +     {.compatible = "riscv,iommu",},
>
> nitpick: Unusual indention:
>
> uwe@...rus:~/gsrc/linux$ git grep -l '{.compatible =' | wc -l
> 192
> uwe@...rus:~/gsrc/linux$ git grep -l '{ .compatible =' | wc -l
> 4197
>
> (Hu, I expected the difference to be bigger than a factor of ~20.)
>
> I'd go for a space before ".compatible" and one after the trailing
> comma.
>
> > +     {},
> > +};
> > +
> > +static struct platform_driver riscv_iommu_platform_driver = {
> > +     .probe = riscv_iommu_platform_probe,
> > +     .remove_new = riscv_iommu_platform_remove,
> > +     .driver = {
> > +             .name = "riscv,iommu",
> > +             .of_match_table = riscv_iommu_of_match,
> > +             .suppress_bind_attrs = true,
> > +     },
> > +};
>
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
>

Thank you for those comments, they look reasonable.
Can we postpone those changes after v10 is merged into the iommu subsystem tree?

> Best regards
> Uwe

Best regards,
- Tomasz