linux-kernel - The "make headers" requirement, revisited: [PATCH v3 3/3] selftests: pidfd: add tests for PIDFD_SELF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6dd57f0e-34b4-4456-854b-a8abdba9163b@nvidia.com>
Date: Wed, 16 Oct 2024 19:01:25 -0700
From: John Hubbard <jhubbard@...dia.com>
To: Shuah Khan <skhan@...uxfoundation.org>, Lorenzo Stoakes
	<lorenzo.stoakes@...cle.com>, Christian Brauner <christian@...uner.io>,
	"Peter Zijlstra" <peterz@...radead.org>
CC: Shuah Khan <shuah@...nel.org>, "Liam R . Howlett"
	<Liam.Howlett@...cle.com>, Suren Baghdasaryan <surenb@...gle.com>, "Vlastimil
 Babka" <vbabka@...e.cz>, <pedro.falcato@...il.com>,
	<linux-kselftest@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-fsdevel@...r.kernel.org>, <linux-api@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Oliver Sang <oliver.sang@...el.com>
Subject: The "make headers" requirement, revisited: [PATCH v3 3/3] selftests:
 pidfd: add tests for PIDFD_SELF_*

On 10/16/24 1:00 PM, Shuah Khan wrote:
> On 10/16/24 04:20, Lorenzo Stoakes wrote:
...
>> diff --git a/tools/testing/selftests/pidfd/pidfd.h b/tools/testing/selftests/pidfd/pidfd.h
>> index 88d6830ee004..1640b711889b 100644
>> --- a/tools/testing/selftests/pidfd/pidfd.h
>> +++ b/tools/testing/selftests/pidfd/pidfd.h
>> @@ -50,6 +50,14 @@
>>   #define PIDFD_NONBLOCK O_NONBLOCK
>>   #endif
>> +/* System header file may not have this available. */
>> +#ifndef PIDFD_SELF_THREAD
>> +#define PIDFD_SELF_THREAD -100
>> +#endif
>> +#ifndef PIDFD_SELF_THREAD_GROUP
>> +#define PIDFD_SELF_THREAD_GROUP -200
>> +#endif
>> +
> 
> As mentioned in my response to v1 patch:
> 
> kselftest has dependency on "make headers" and tests include
> headers from linux/ directory

Wait, what?! Noooo!

Hi, Shuah! :)

We have had this conversation before. And there were fireworks coming from
various core kernel developers who found that requirement to be unacceptable.

And in response, I made at selftests/mm tests buildable *without* requiring
a "make headers" first, in [1].

I haven't followed up with other subsystems, but...maybe I should. Because
otherwise we're just going to keep having this discussion.

The requirement to do "make headers" is not a keeper. Really.

> 
> These local make it difficult to maintain these tests in the
> longer term. Somebody has to go clean these up later.

There are other approaches to making things work. Again, please see [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e076eaca5906


thanks,
-- 
John Hubbard