linux-kernel - Re: [PATCH] crypto: qat - Constify struct pm_status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxFuq6itT2KylMQg@gcabiddu-mobl.ger.corp.intel.com>
Date: Thu, 17 Oct 2024 21:08:11 +0100
From: "Cabiddu, Giovanni" <giovanni.cabiddu@...el.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>, <qat-linux@...el.com>,
	<linux-crypto@...r.kernel.org>
Subject: Re: [PATCH] crypto: qat - Constify struct pm_status_row

On Mon, Oct 14, 2024 at 09:55:17PM +0200, Christophe JAILLET wrote:
> 'struct pm_status_row' are not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increases overall security.
> 
> Update the prototype of some functions accordingly.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>    4400	   1059	      0	   5459	   1553	drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>    5216	    243	      0	   5459	   1553	drivers/crypto/intel/qat/qat_common/adf_gen4_pm_debugfs.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

Thanks,

-- 
Giovanni