linux-kernel - Re: [PATCH v2] kbuild: Move -Wenum-enum-conversion to W=2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <079876f3-19c6-41bf-8e70-8764fd4c62e4@app.fastmail.com>
Date: Thu, 17 Oct 2024 20:19:54 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Nathan Chancellor" <nathan@...nel.org>,
 "Masahiro Yamada" <masahiroy@...nel.org>
Cc: "Nicolas Schier" <nicolas@...sle.eu>,
 "Nick Desaulniers" <ndesaulniers@...gle.com>,
 "Bill Wendling" <morbo@...gle.com>, "Justin Stitt" <justinstitt@...gle.com>,
 "Aleksei Vetrov" <vvvvvv@...gle.com>, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, patches@...ts.linux.dev,
 stable@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: Move -Wenum-enum-conversion to W=2

On Thu, Oct 17, 2024, at 17:09, Nathan Chancellor wrote:
> -Wenum-enum-conversion was strengthened in clang-19 to warn for C, which
> caused the kernel to move it to W=1 in commit 75b5ab134bb5 ("kbuild:
> Move -Wenum-{compare-conditional,enum-conversion} into W=1") because
> there were numerous instances that would break builds with -Werror.
> Unfortunately, this is not a full solution, as more and more developers,
> subsystems, and distributors are building with W=1 as well, so they
> continue to see the numerous instances of this warning.
>
> Since the move to W=1, there have not been many new instances that have
> appeared through various build reports and the ones that have appeared
> seem to be following similar existing patterns, suggesting that most
> instances of this warning will not be real issues. The only alternatives
> for silencing this warning are adding casts (which is generally seen as
> an ugly practice) or refactoring the enums to macro defines or a unified
> enum (which may be undesirable because of type safety in other parts of
> the code).
>
> Move the warning to W=2, where warnings that occur frequently but may be
> relevant should reside.
>
> Cc: stable@...r.kernel.org
> Fixes: 75b5ab134bb5 ("kbuild: Move 
> -Wenum-{compare-conditional,enum-conversion} into W=1")
> Link: https://lore.kernel.org/ZwRA9SOcOjjLJcpi@google.com/
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Acked-by: Arnd Bergmann <arnd@...db.de>