linux-kernel - Re: [PATCH v4 15/28] cxl/region: Refactor common create region code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6711738e4caae_2cee294da@iweiny-mobl.notmuch>
Date: Thu, 17 Oct 2024 15:29:02 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Ira Weiny
	<ira.weiny@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, Fan Ni <fan.ni@...sung.com>, "Navneet
 Singh" <navneet.singh@...el.com>, Jonathan Corbet <corbet@....net>, "Andrew
 Morton" <akpm@...ux-foundation.org>, Dan Williams <dan.j.williams@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, Alison Schofield
	<alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>,
	<linux-btrfs@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 15/28] cxl/region: Refactor common create region code

Jonathan Cameron wrote:
> On Mon, 07 Oct 2024 18:16:21 -0500
> Ira Weiny <ira.weiny@...el.com> wrote:
> 
> > create_pmem_region_store() and create_ram_region_store() are identical
> > with the exception of the region mode.  With the addition of DC region
> > mode this would end up being 3 copies of the same code.
> > 
> > Refactor create_pmem_region_store() and create_ram_region_store() to use
> > a single common function to be used in subsequent DC code.
> > 
> > Suggested-by: Fan Ni <fan.ni@...sung.com>
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> Nice.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 
> Is it worth dragging out cleanup like this to the start of the series so
> Dave can queue it up as 'good to have whatever' and reduce this set
> a bit?

The problem was that this patch depended on the region mode change...  But
that was an easy change.

I've moved it forward.

Ira