linux-kernel - Re: [PATCH] genirq/devres: Simplify API devm_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y12m8o76.ffs@tglx>
Date: Thu, 17 Oct 2024 22:33:01 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Zijun Hu <zijun_hu@...oud.com>, linux-kernel@...r.kernel.org, Zijun Hu
 <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH] genirq/devres: Simplify API devm_free_irq() implementation

On Thu, Oct 17 2024 at 23:16, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
>
> Simplify devm_free_irq() implementation by dedicated API devres_release()
> which have below advantages than current devres_destroy() + free_irq().
>
> It is simpler if devm_free_irq() is undoing what any devm_request_irq()
> variant did, otherwise, it can avoid wrong and undesired free_irq().

This is confusing at best. What's the wrong an undesired free_irq()?

Thanks,

        tglx