linux-kernel - Re: [PATCH] of: Allow overlay kunit tests to run CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017203810.GA814469-robh@kernel.org>
Date: Thu, 17 Oct 2024 15:38:10 -0500
From: Rob Herring <robh@...nel.org>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Saravana Kannan <saravanak@...gle.com>, linux-kernel@...r.kernel.org,
	patches@...ts.linux.dev, devicetree@...r.kernel.org,
	kunit-dev@...glegroups.com
Subject: Re: [PATCH] of: Allow overlay kunit tests to run CONFIG_OF_OVERLAY=n

On Wed, Oct 16, 2024 at 02:20:15PM -0700, Stephen Boyd wrote:
> Some configurations want to enable CONFIG_KUNIT without enabling
> CONFIG_OF_OVERLAY. The kunit overlay code already skips if
> CONFIG_OF_OVERLAY isn't enabled, so this select here isn't really doing
> anything besides making it easier to run the tests without them
> skipping. Remove the select and move the config setting to the
> drivers/of/.kunitconfig file so that the overlay tests can be run with
> or without CONFIG_OF_OVERLAY set to test either behavior.
> 
> Fixes: 5c9dd72d8385 ("of: Add a KUnit test for overlays and test managed APIs")

Doesn't really seem like a fix. Does this need to go into 6.12?

> Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> ---
>  drivers/of/.kunitconfig   | 1 +
>  drivers/of/Kconfig        | 1 -
>  drivers/of/overlay_test.c | 2 ++
>  3 files changed, 3 insertions(+), 1 deletion(-)