linux-kernel - Re: [PATCH 3/3] riscv: add PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-02463d30-c55e-41a9-beae-ac4cdff9fc9f@palmer-ri-x1c9a>
Date: Thu, 17 Oct 2024 14:49:49 -0700 (PDT)
From: Palmer Dabbelt <palmer@...belt.com>
To: bigeasy@...utronix.de
CC: peterz@...radead.org, linux-trace-kernel@...r.kernel.org,
  linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...nel.org, juri.lelli@...hat.com,
  vincent.guittot@...aro.org, dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
  mgorman@...e.de, vschneid@...hat.com, ankur.a.arora@...cle.com, efault@....de,
  mhiramat@...nel.org, mathieu.desnoyers@...icios.com, jszhang@...nel.org,
  Paul Walmsley <paul.walmsley@...ive.com>, aou@...s.berkeley.edu, linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH 3/3] riscv: add PREEMPT_LAZY support

On Wed, 09 Oct 2024 06:05:30 PDT (-0700), bigeasy@...utronix.de wrote:
> On 2024-10-09 15:03:07 [+0200], Peter Zijlstra wrote:
>> > diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h
>> > index 9c10fb180f438..8b5a5ddea4293 100644
>> > --- a/arch/riscv/include/asm/thread_info.h
>> > +++ b/arch/riscv/include/asm/thread_info.h
>> > @@ -107,6 +107,7 @@ int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src);
>> >   * - pending work-to-be-done flags are in lowest half-word
>> >   * - other flags in upper half-word(s)
>> >   */
>> > +#define TIF_NEED_RESCHED_LAZY	0       /* Lazy rescheduling needed */
>> >  #define TIF_NOTIFY_RESUME	1	/* callback before returning to user */
>> >  #define TIF_SIGPENDING		2	/* signal pending */
>> >  #define TIF_NEED_RESCHED	3	/* rescheduling necessary */
>>
>> So for x86 I shuffled the flags around to have the two NEED_RESCHED ones
>> side-by-side. Not strictly required ofcourse, but...
>
> I can shuffle them. I don't think the riscv camp will complain (saying
> this for them to actual complain if so).

Acked-by: Palmer Dabbelt <palmer@...osinc.com>