linux-kernel - Re: [PATCH] remoteproc: qcom_q6v5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mvzwlbeopenn5hpll3rmkdwcc7r7ir263nwvlh2hiy73qeipl6@nh4angyrt5p2>
Date: Fri, 18 Oct 2024 01:29:21 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Balaji Pothunoori <quic_bpothuno@...cinc.com>
Cc: andersson@...nel.org, mathieu.poirier@...aro.org, 
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	ath11k@...ts.infradead.org, Kalle Valo <kvalo@...nel.org>
Subject: Re: [PATCH] remoteproc: qcom_q6v5_pas: disable auto boot for wpss

On Wed, Oct 16, 2024 at 07:24:09PM +0530, Balaji Pothunoori wrote:
> auto_boot flag ensures to take the firmware and boots it
> up during the wpss remoteproc start.
> wpss host driver would like to control the load and unload
> of the firmware during the load and unload of the driver.
> Hence, disable the "auto boot" for wpss.

Which driver? What is the reason for manual control?
The board seems to function properly with the ath11k driver, which
doesn't seem to require manual control.

> 
> Signed-off-by: Balaji Pothunoori <quic_bpothuno@...cinc.com>
> ---
> Cc: ath11k@...ts.infradead.org
> Cc: Kalle Valo <kvalo@...nel.org>
> ---
>  drivers/remoteproc/qcom_q6v5_pas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index ef82835e98a4..05963d7924df 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1344,7 +1344,7 @@ static const struct adsp_data sc7280_wpss_resource = {
>  	.crash_reason_smem = 626,
>  	.firmware_name = "wpss.mdt",
>  	.pas_id = 6,
> -	.auto_boot = true,
> +	.auto_boot = false,
>  	.proxy_pd_names = (char*[]){
>  		"cx",
>  		"mx",
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry