linux-kernel - Re: [PATCH v3] drm/display: Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c633a57f-7f22-41e0-8b3d-bd95ad212e9b@quicinc.com>
Date: Thu, 17 Oct 2024 15:52:06 -0700
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Jean Delvare <jdelvare@...e.de>, <dri-devel@...ts.freedesktop.org>,
        LKML
	<linux-kernel@...r.kernel.org>
CC: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard
	<mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
        Doug Anderson
	<dianders@...omium.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH v3] drm/display: Drop obsolete dependency on COMPILE_TEST



On 10/15/2024 4:46 AM, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> To avoid reintroducing the randconfig bug originally fixed by commit
> 876271118aa4 ("drm/display: Fix build error without CONFIG_OF"),
> DRM_MSM which selects DRM_DISPLAY_DP_HELPER must explicitly depend
> on OF. This is consistent with what all other DRM drivers are doing.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> ---
> For regular builds, this is a no-op, as OF is always enabled on
> ARCH_QCOM and SOC_IMX5. So this change only affects test builds. As
> explained before, allowing test builds only when OF is enabled
> improves the quality of these test builds, as the result is then
> closer to how the code is built on its intended targets.
> 
> Changes in v3:
> * Rebase on top of kernel v6.11.
> Changes in v2:
> * Let DRM_MSM depend on OF so that random test builds won't break.
> 
>   drivers/gpu/drm/display/Kconfig |    2 +-
>   drivers/gpu/drm/msm/Kconfig     |    1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>