linux-kernel - Re: [PATCH v7 9/9] docs: tmpfs: Add casefold options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <787b22d1-7072-4ab7-8314-3f1fd15e5a22@infradead.org>
Date: Thu, 17 Oct 2024 16:13:01 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: André Almeida <andrealmeid@...lia.com>,
 Gabriel Krisman Bertazi <krisman@...nel.org>,
 Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>,
 Hugh Dickins <hughd@...gle.com>, Andrew Morton <akpm@...ux-foundation.org>,
 Jonathan Corbet <corbet@....net>, smcv@...labora.com
Cc: kernel-dev@...lia.com, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org,
 linux-mm@...ck.org, linux-doc@...r.kernel.org,
 Gabriel Krisman Bertazi <krisman@...e.de>
Subject: Re: [PATCH v7 9/9] docs: tmpfs: Add casefold options

Hi,

On 10/17/24 2:14 PM, André Almeida wrote:
> Document mounting options for casefold support in tmpfs.
> 
> Signed-off-by: André Almeida <andrealmeid@...lia.com>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@...e.de>
> ---
> Changes from v3:
> - Rewrote note about "this doesn't enable casefold by default" (Krisman)
> ---
>  Documentation/filesystems/tmpfs.rst | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/filesystems/tmpfs.rst b/Documentation/filesystems/tmpfs.rst
> index 56a26c843dbe964086503dda9b4e8066a1242d72..0385310f225808f55483413f2c69d3b6dc1b9913 100644
> --- a/Documentation/filesystems/tmpfs.rst
> +++ b/Documentation/filesystems/tmpfs.rst
> @@ -241,6 +241,28 @@ So 'mount -t tmpfs -o size=10G,nr_inodes=10k,mode=700 tmpfs /mytmpfs'
>  will give you tmpfs instance on /mytmpfs which can allocate 10GB
>  RAM/SWAP in 10240 inodes and it is only accessible by root.
>  
> +tmpfs has the following mounting options for case-insensitive lookup support:
> +
> +================= ==============================================================
> +casefold          Enable casefold support at this mount point using the given
> +                  argument as the encoding standard. Currently only UTF-8
> +                  encodings are supported. If no argument is used, it will load
> +                  the latest UTF-8 encoding available.
> +strict_encoding   Enable strict encoding at this mount point (disabled by
> +                  default). In this mode, the filesystem refuses to create file
> +                  and directory with names containing invalid UTF-8 characters.
> +================= ==============================================================
> +
> +This option doesn't render the entire filesystem case-insensitive. One needs to
> +still set the casefold flag per directory, by flipping +F attribute in an empty

I would say:                                     flipping the +F attribute

> +directory. Nevertheless, new directories will inherit the attribute. The
> +mountpoint itself cannot be made case-insensitive.
> +
> +Example::
> +
> +    $ mount -t tmpfs -o casefold=utf8-12.1.0,strict_encoding fs_name /mytmpfs
> +    $ mount -t tmpfs -o casefold fs_name /mytmpfs
> +
>  
>  :Author:
>     Christoph Rohland <cr@....com>, 1.12.01
> @@ -250,3 +272,5 @@ RAM/SWAP in 10240 inodes and it is only accessible by root.
>     KOSAKI Motohiro, 16 Mar 2010
>  :Updated:
>     Chris Down, 13 July 2020
> +:Updated:
> +   André Almeida, 23 Aug 2024
> 

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

-- 
~Randy