[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <679e9acc-3d76-43dc-a00f-9301a1da0ce6@linux.alibaba.com>
Date: Fri, 18 Oct 2024 07:41:47 +0800
From: Shuai Xue <xueshuai@...ux.alibaba.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc: mark.rutland@....com, catalin.marinas@....com, mingo@...hat.com,
robin.murphy@....com, bp@...en8.de, rafael@...nel.org,
wangkefeng.wang@...wei.com, tanxiaofei@...wei.com, mawupeng1@...wei.com,
tony.luck@...el.com, linmiaohe@...wei.com, naoya.horiguchi@....com,
james.morse@....com, tongtiangen@...wei.com, gregkh@...uxfoundation.org,
will@...nel.org, jarkko@...nel.org, linux-acpi@...r.kernel.org,
linux-mm@...ck.org, linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
linux-edac@...r.kernel.org, x86@...nel.org, justin.he@....com,
ardb@...nel.org, ying.huang@...el.com, ashish.kalra@....com,
baolin.wang@...ux.alibaba.com, tglx@...utronix.de,
dave.hansen@...ux.intel.com, lenb@...nel.org, hpa@...or.com,
robert.moore@...el.com, lvying6@...wei.com, xiexiuqi@...wei.com,
zhuo.song@...ux.alibaba.com, linux-cxl@...r.kernel.org
Subject: Re: [PATCH v14 1/3] ACPI: APEI: send SIGBUS to current task if
synchronous memory error not recovered
在 2024/10/17 17:39, Jonathan Cameron 写道:
> On Mon, 14 Oct 2024 16:42:38 +0800
> Shuai Xue <xueshuai@...ux.alibaba.com> wrote:
>
>> Synchronous error was detected as a result of user-space process accessing
>> a 2-bit uncorrected error. The CPU will take a synchronous error exception
>> such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a
>> memory_failure() work which poisons the related page, unmaps the page, and
>> then sends a SIGBUS to the process, so that a system wide panic can be
>> avoided.
>>
>> However, no memory_failure() work will be queued when abnormal synchronous
>> errors occur. These errors can include situations such as invalid PA,
>> unexpected severity, no memory failure config support, invalid GUID
>> section, etc. In such case, the user-space process will trigger SEA again.
>> This loop can potentially exceed the platform firmware threshold or even
>> trigger a kernel hard lockup, leading to a system reboot.
>>
>> Fix it by performing a force kill if no memory_failure() work is queued
>> for synchronous errors.
>>
>> Signed-off-by: Shuai Xue <xueshuai@...ux.alibaba.com>
>> Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
>
> The subtle cases in here are the various other forms of delayed handling
> buried in some of the record handling that don't set queued.
> I've been through them all and have convinced myself that either
> hey should never be synchronous or that there is no attempt to
> recover in kernel today (non memory things such as CXL protocol
> collapse, which might I guess be detected synchronously on a read
> - though I'd expect poison and a memory error first) so the correct
> thing to do is what you have here.
>
> Fiddly code though with a lot of paths, so more eyes welcome!
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>
> +CC linux-cxl for info.
Thanks :)
Best Regards,
Shuai
Powered by blists - more mailing lists