linux-kernel - Re: [PATCH v3 10/14] x86/cpu: Enable SD_ASYM_PACKING for DIE Domain on AMD Processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxCpVfcOAn0PYNwa@BLRRASHENOY1.amd.com>
Date: Thu, 17 Oct 2024 11:36:13 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@....com>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Borislav Petkov <bp@...en8.de>, Hans de Goede <hdegoede@...hat.com>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	x86@...nel.org, Perry Yuan <perry.yuan@....com>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-pm@...r.kernel.org, platform-driver-x86@...r.kernel.org,
	Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v3 10/14] x86/cpu: Enable SD_ASYM_PACKING for DIE Domain
 on AMD Processors

On Tue, Oct 15, 2024 at 04:36:41PM -0500, Mario Limonciello wrote:
> From: Perry Yuan <perry.yuan@....com>
> 
> Enable the SD_ASYM_PACKING domain flag for the DIE domain on AMD

Nit: It is called the PKG domain now instead of the DIE domain.

# grep . /sys/kernel/debug/sched/domains/cpu0/domain*/name
/sys/kernel/debug/sched/domains/cpu0/domain0/name:SMT
/sys/kernel/debug/sched/domains/cpu0/domain1/name:MC
/sys/kernel/debug/sched/domains/cpu0/domain2/name:PKG <----
/sys/kernel/debug/sched/domains/cpu0/domain3/name:NUMA


> heterogeneous processors.
> This flag is beneficial for processors with one or more CCDs and
> relies on x86_sched_itmt_flags().
> 
> Signed-off-by: Perry Yuan <perry.yuan@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Looks good to me otherwise.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@....com>

> ---
>  arch/x86/kernel/smpboot.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> index 766f092dab80..c01bb75d0375 100644
> --- a/arch/x86/kernel/smpboot.c
> +++ b/arch/x86/kernel/smpboot.c
> @@ -497,8 +497,9 @@ static int x86_cluster_flags(void)
>  
>  static int x86_die_flags(void)
>  {
> -	if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU))
> -	       return x86_sched_itmt_flags();
> +	if (cpu_feature_enabled(X86_FEATURE_HYBRID_CPU) ||
> +	    cpu_feature_enabled(X86_FEATURE_HETERO_CORE_TOPOLOGY))
> +		return x86_sched_itmt_flags();
>  
>  	return 0;
>  }
> -- 
> 2.43.0
>