linux-kernel - Re: [PATCH net-next 12/13] net: fec: fec_enet_rx_queue(): move_call to _vlan_hwaccel_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017-modest-warping-potoo-c938d0-mkl@pengutronix.de>
Date: Thu, 17 Oct 2024 09:05:07 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Frank Li <Frank.li@....com>
Cc: Wei Fang <wei.fang@....com>, Shenwei Wang <shenwei.wang@....com>, 
	Clark Wang <xiaoning.wang@....com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>, imx@...ts.linux.dev, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH net-next 12/13] net: fec: fec_enet_rx_queue(): move_call
 to _vlan_hwaccel_put_tag()

On 16.10.2024 23:05:27, Frank Li wrote:
> On Wed, Oct 16, 2024 at 11:52:00PM +0200, Marc Kleine-Budde wrote:
> > To clean up the VLAN handling, move the call to
> > __vlan_hwaccel_put_tag() into the body of the if statement, which
> > checks for VLAN handling in the first place.
> >
> > This allows to remove vlan_packet_rcvd and reduce the scope of
> > vlan_tag.
> 
> Move __vlan_hwaccel_put_tag() into the if statement that sets
> vlan_packet_rcvd=true. This change eliminates the unnecessary
> vlan_packet_rcvd variable, simplifying the code and improving clarity.

Fixed,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)