[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2497f65b-0041-4454-9d72-a1c6699ba1a7@arm.com>
Date: Thu, 17 Oct 2024 12:50:31 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Nanyong Sun <sunnanyong@...wei.com>, shuah@...nel.org,
zokeefe@...gle.com, linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org, wangkefeng.wang@...wei.com
Subject: Re: [PATCH] selftests: mm: fix the incorrect usage() info of
khugepaged
On 10/17/24 12:44, Andrew Morton wrote:
> On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual <anshuman.khandual@....com> wrote:
>
>> On 10/15/24 07:32, Nanyong Sun wrote:
>>> The mount option of tmpfs should be huge=advise, not madvise
>>> which is not supported and may mislead the users.
>> Agreed.
>>
>>> Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing")
>> But nothing is really broken here. This just fixes usage information.
> The usage information is broken!
>
>> Please drop the "Fixes:".
> Fixes: is appropriate. It tells people which commit introduced the error.
>
> I don't think it's serious enough to add a cc:stable. Others might disagree.
Alright, usage information is part of the functionality itself.
Powered by blists - more mailing lists