linux-kernel - Re: [PATCH v1 1/2] dt-bindings: clock: Add Qualcomm SM6115 LPASS clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <n4nbzwostn6i5ygskjfr4o7haqujodadxd2kspvlk2gccxoaen@pk3qj7rxvspf>
Date: Thu, 17 Oct 2024 10:39:27 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexey Klimov <alexey.klimov@...aro.org>
Cc: konradybcio@...nel.org, konrad.dybcio@....qualcomm.com, 
	andersson@...nel.org, mturquette@...libre.com, sboyd@...nel.org, krzk+dt@...nel.org, 
	robh@...nel.org, conor+dt@...nel.org, srinivas.kandagatla@...aro.org, 
	linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: clock: Add Qualcomm SM6115 LPASS
 clock controller

On Thu, Oct 17, 2024 at 01:57:59AM +0100, Alexey Klimov wrote:
> From: Konrad Dybcio <konrad.dybcio@...aro.org>
> 
> SM6115 (and its derivatives or similar SoCs) has an LPASS clock
> controller block which provides audio-related resets.
> 
> Add bindings for it.

That's a v2.

> 
> Cc: Konrad Dybcio <konradybcio@...nel.org>
> Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> [alexey.klimov] slightly changed the commit message
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>

My tag?

> ---
>  .../bindings/clock/qcom,sm6115-lpasscc.yaml   | 53 +++++++++++++++++++
>  .../dt-bindings/clock/qcom,sm6115-lpasscc.h   | 15 ++++++
>  2 files changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,sm6115-lpasscc.yaml
>  create mode 100644 include/dt-bindings/clock/qcom,sm6115-lpasscc.h
> +examples:
> +  - |
> +    lpass_audiocc: clock-controller@...9000 {
> +        compatible = "qcom,sm6115-lpassaudiocc";
> +        reg = <0x0a6a9000 0x1000>;
> +        #reset-cells = <1>;
> +    };
> +
> +  - |
> +    lpasscc: clock-controller@...c000 {
> +        compatible = "qcom,sm6115-lpasscc";
> +        reg = <0x0a7ec000 0x1000>;
> +        #reset-cells = <1>;
> +    };

Not much improved. Don't send same code from whatever repo you got, but
go via mailing list.

Best regards,
Krzysztof