linux-kernel - Re: [RFC PATCH] pinctrl: pinmux: Introduce API to check if a pin is requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8vQYJKqxKkGtduFuT9865jscn61gTw-iQHcyfh9O_9UzA@mail.gmail.com>
Date: Thu, 17 Oct 2024 09:47:32 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Geert Uytterhoeven <geert+renesas@...der.be>, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [RFC PATCH] pinctrl: pinmux: Introduce API to check if a pin is requested

Hi Linus,

Thank you for the review.

On Tue, Oct 15, 2024 at 10:43 PM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> Hi Prabhakar,
>
> thanks for your patch!
>
> On Tue, Oct 15, 2024 at 6:21 PM Prabhakar <prabhakar.csengg@...il.com> wrote:
>
>
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Introduce `pin_requestesd` API to check if a pin is currently requested.
>
> What kind of function name is this?
>
> Do you mean
>
> pin_requested()?
>
Ouch, I will fix that.

> > This API allows pinctrl drivers to verify whether a pin is requested or
> > not by checking if the pin is owned by either `gpio_owner` or `mux_owner`.
>
> There is nothing wrong with the patch as such, but it needs to be
> illustrated by submitting it together with the first intended user
> and show how it is used, we don't add upfront APIs.
>
Sure, I will post the patches.

Cheers,
Prabhakar