linux-kernel - Re: [PATCH] staging: gpib: Change return type and error code of fluke_get_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85cb4aba-60ca-4fea-8d1c-dd01578357b5@stanley.mountain>
Date: Thu, 17 Oct 2024 12:00:59 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: "Everest K.C." <everestkc@...restkc.com.np>
Cc: dpenkler@...il.com, gregkh@...uxfoundation.org,
	skhan@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Change return type and error code of
 fluke_get_dma_residue

On Thu, Oct 17, 2024 at 02:20:22AM -0600, Everest K.C. wrote:
> fluke_get_dma_residue() returns unsigned int with -1 as error code.
> This error cannot be caught.
> Fix this by changing the return type of the function to int and 
> returning the error code, that was captured.
> 
> Fixes: 55936779f496 ("staging: gpib: Add Fluke cda based cards GPIB driver")
> Signed-off-by: Everest K.C. <everestkc@...restkc.com.np>
> ---

So like quite often we would merge a patch like this, because there's nothing
wrong with it and why not?  It's a step in the right direction.  But actually
in this case could you fix the caller as well?

Do it all in the same patch.  It's the one *whole* thing per patch rule.

regards,
dan carpenter