linux-kernel - Re: [PATCH RFC v2 2/2] dt-bindings: clock: ti: Convert divider.txt to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241017123802.2a1fff05@akair>
Date: Thu, 17 Oct 2024 12:38:02 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Rob Herring <robh@...nel.org>
Cc: Aaro Koskinen <aaro.koskinen@....fi>, Tony Lindgren <tony@...mide.com>,
 Roger Quadros <rogerq@...nel.org>, linux-omap@...r.kernel.org, Kevin Hilman
 <khilman@...libre.com>, devicetree@...r.kernel.org,
 linux-clk@...r.kernel.org, Tero Kristo <kristo@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd <sboyd@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v2 2/2] dt-bindings: clock: ti: Convert divider.txt
 to json-schema

Am Wed, 9 Oct 2024 22:44:34 -0500
schrieb Rob Herring <robh@...nel.org>:

> > +
> > +  ti,min-div:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      min divisor for dividing the input clock rate, only
> > +      needed if the first divisor is offset from the default value
> > (1)  
> 
> minimum: 1
> maximum: ?
> default: 1

maximum is complex: there is one place in the code where this runs
through a u8 (_get_val). although it it read from the devicetree as a
uint32.
So, if we do not care about a specific implementation, then
in the power-of-two case, the theoretical maximum would be 1 << (1 <<
(32-bitshift) - 1) clipped to UINT32_MAX due to type constraints. And
also the maximum lifetime of electronics and elementary elements and
pieces, probably even with the proposed decay time of protons.
In the index-starts-at-case, we would have (1 << (32-bitshift)) - 1.
otherwise 1 << (32-bitshift).

I would propose not to define a maximum here.

Regards,
Andreas