linux-kernel - Re: [PATCH] scripts: add `uapi` crate to `generate_rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH5fLghcW5HgHaV43++Pdf4i7kPQ3CbJKmNmACUyw8iZDWzt3g@mail.gmail.com>
Date: Thu, 17 Oct 2024 13:35:48 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Luna Xin <luna.xin.lx@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: add `uapi` crate to `generate_rust_analyzer.py`

On Mon, Oct 7, 2024 at 1:03 AM Luna Xin <luna.xin.lx@...il.com> wrote:
>
> This patch updates the `generate_rust_analyzer.py` script to include
> the `uapi` crate.
>
> This allows a proper `rust-project.json` to be generated by the script
> so that driver developers can take advantage of rust-analyzer code
> completions when interfacing with `uapi`.
>
> Signed-off-by: Luna Xin <luna.xin.lx@...il.com>
> ---
>  scripts/generate_rust_analyzer.py | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index d2bc63cde..61214fd2f 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -93,10 +93,18 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs):
>      )
>      crates[-1]["env"]["OBJTREE"] = str(objtree.resolve(True))
>
> +    append_crate(
> +        "uapi",
> +        srctree / "rust"/ "uapi" / "lib.rs",
> +        ["core"],
> +        cfg=cfg,
> +    )
> +    crates[-1]["env"]["OBJTREE"] = str(objtree.resolve(True))

This says that uapi only depends on core, but how does that interact
with this patch?

https://lore.kernel.org/all/20240913213041.395655-1-gary@garyguo.net/

Alice