linux-kernel - Re: [PATCH v8 2/2] ARM: dts: mxs: Add descriptions for imx287 based btt3-[012] devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37c2d19b-b2b2-4f60-b057-90953c5f9958@gmx.net>
Date: Thu, 17 Oct 2024 14:10:40 +0200
From: Stefan Wahren <wahrenst@....net>
To: Lukasz Majewski <lukma@...x.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>
Cc: Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 2/2] ARM: dts: mxs: Add descriptions for imx287 based
 btt3-[012] devices

Hi Lukasz,

Am 17.10.24 um 10:35 schrieb Lukasz Majewski:
> Hi Stefan,
>
>> The btt3 device' HW revisions from 0 to 2 use imx287 SoC and are to
>> some extend similar to already upstreamed XEA devices, hence are
>> using common imx28-lwe.dtsi file.
>>
>> New, imx28-btt3.dtsi has been added to embrace common DTS
>> properties for different HW revisions for this device.
>>
>> As a result - changes introduced in imx28-btt3-[012].dts are
>> minimal.
>>
> Stefan, do you have comments for this version?
>
>> Signed-off-by: Lukasz Majewski <lukma@...x.de>
>>
>> ---
>> Changes for v2:
>> - Rename dts file from btt3-[012] to imx28-btt3-[012] to match current
>>    linux kernel naming convention
>> - Remove 'wlf,wm8974' from compatible for codec@1a
>>
>> Changes for v3:
>> - Keep alphabethical order for Makefile entries
>>
>> Changes for v4:
>> - Change compatible for btt3 board (to 'lwn,imx28-btt3')
>>
>> Changes for v5:
>> - Combine patch, which adds btt3-[012] with one adding board entry to
>>    fsl.yaml
>>
>> Changes for v6:
>> - Make the patch series for adding entry in fsl.yaml and btt3
>>
>> Changes for v7:
>> - Use "panel" property as suggested by the community
>> - Use panel-timing to specify the display parameters
>> - Update subject line with correct tags
>>
>> Changes for v8:
>> - Use GPIO_ACTIVE_HIGH instead of '0'
>> - Add the comment regarding mac address specification
>> - Remove superfluous comment
>> - Change wifi-en-pin node name
>> ---
>>   arch/arm/boot/dts/nxp/mxs/Makefile         |   3 +
>>   arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts |  12 +
>>   arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts |   8 +
>>   arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts |  40 +++
>>   arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi  | 313
>> +++++++++++++++++++++ 5 files changed, 376 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts
>>   create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts
>>   create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts
>>   create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi
>>
...
>> +
>> +&ssp1 {
>> +	compatible = "fsl,imx28-mmc";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&ssp1_sdio_pins_a>;
>> +	bus-width = <4>;
>> +	no-1-8-v;       /* force 3.3V VIO */
>> +	pm-ignore-notify;
I think this slipped through?

Regards