linux-kernel - Re: [PATCH v2] fs: Fix uninitialized value issue in from_kuid and from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241017-flausen-verwoben-b07eb6d72070@brauner>
Date: Thu, 17 Oct 2024 15:32:16 +0200
From: Christian Brauner <brauner@...nel.org>
To: Alessandro Zanni <alessandro.zanni87@...il.com>
Cc: Christian Brauner <brauner@...nel.org>,
	linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	skhan@...uxfoundation.org,
	anupnewsmail@...il.com,
	alessandrozanni.dev@...il.com,
	syzbot+6c55f725d1bdc8c52058@...kaller.appspotmail.com,
	viro@...iv.linux.org.uk,
	jack@...e.cz
Subject: Re: [PATCH v2] fs: Fix uninitialized value issue in from_kuid and from_kgid

On Thu, 17 Oct 2024 14:05:51 +0200, Alessandro Zanni wrote:
> ocfs2_setattr() uses attr->ia_mode, attr->ia_uid and attr->ia_gid in
> a trace point even though ATTR_MODE, ATTR_UID and ATTR_GID aren't set.
> 
> Initialize all fields of newattrs to avoid uninitialized variables, by
> checking if ATTR_MODE, ATTR_UID, ATTR_GID are initialized, otherwise 0.
> 
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] fs: Fix uninitialized value issue in from_kuid and from_kgid
      https://git.kernel.org/vfs/vfs/c/eeb1277262f8