lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241017133933.GA31667@francesco-nb>
Date: Thu, 17 Oct 2024 15:39:33 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Francesco Dolcini <francesco@...cini.it>,
	Olivia Mackall <olivia@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Francesco Dolcini <francesco.dolcini@...adex.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Aurelien Jarno <aurelien@...el32.net>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-crypto@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Lorenzo Bianconi <lorenzo@...nel.org>,
	upstream@...oha.com
Subject: Re: [PATCH 2/2] hwrng: add support for Airoha EN7581 TRNG

On Thu, Oct 17, 2024 at 03:13:37PM +0200, Christian Marangi wrote:
> On Thu, Oct 17, 2024 at 03:11:12PM +0200, Francesco Dolcini wrote:
> > On Wed, Oct 16, 2024 at 05:18:42PM +0200, Christian Marangi wrote:
> > > Add support for Airoha TRNG. The Airoha SoC provide a True RNG module
> > > that can output 4 bytes of raw data at times.
> > > 
> > > The module makes use of various noise source to provide True Random
> > > Number Generation.
> > > 
> > > On probe the module is reset to operate Health Test and verify correct
> > > execution of it.
> > > 
> > > The module can also provide DRBG function but the execution mode is
> > > mutually exclusive, running as TRNG doesn't permit to also run it as
> > > DRBG.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > > ---
> > >  drivers/char/hw_random/Kconfig       |  13 ++
> > >  drivers/char/hw_random/Makefile      |   1 +
> > >  drivers/char/hw_random/airoha-trng.c | 243 +++++++++++++++++++++++++++
> > >  3 files changed, 257 insertions(+)
> > >  create mode 100644 drivers/char/hw_random/airoha-trng.c
> > > 
> > > diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> > > index 5912c2dd6398..bda283f290bc 100644
> > > --- a/drivers/char/hw_random/Kconfig
> > > +++ b/drivers/char/hw_random/Kconfig
> > > @@ -62,6 +62,19 @@ config HW_RANDOM_AMD
> > >  
> > >  	  If unsure, say Y.
> > >  
> > > +config HW_RANDOM_AIROHA
> > > +	tristate "Airoha True HW Random Number Generator support"
> > > +	depends on ARCH_AIROHA || COMPILE_TEST
> > 
> > > +	default HW_RANDOM
> > This should not be always enabled when HW_RANDOM is enabled. Enabling
> > driver should be a opt-in.
> 
> Was following the pattern with other HW_RANDOM config. Ok will drop.

Whoops. I missed that it depends on ARCH_AIROHA. Given that dependency
is fine to me without any change.

Francesco


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ