linux-kernel - Re: [PATCH V1 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88081"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018134721.GA90231-robh@kernel.org>
Date: Fri, 18 Oct 2024 08:47:21 -0500
From: Rob Herring <robh@...nel.org>
To: wangweidong.a@...nic.com
Cc: lgirdwood@...il.com, broonie@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com,
	rf@...nsource.cirrus.com, neil.armstrong@...aro.org,
	pierre-louis.bossart@...ux.dev, luca.ceresoli@...tlin.com,
	arnd@...db.de, quic_pkumpatl@...cinc.com, herve.codina@...tlin.com,
	masahiroy@...nel.org, shenghao-ding@...com,
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, yijiangtao@...nic.com
Subject: Re: [PATCH V1 1/2] ASoC: dt-bindings: Add schema for "awinic,aw88081"

On Fri, Oct 18, 2024 at 05:43:18PM +0800, wangweidong.a@...nic.com wrote:
> From: Weidong Wang <wangweidong.a@...nic.com>
> 
> Add the awinic,aw88081 property to the awinic,aw88395.yaml file.

That is obvious from reading the diff. Please say something about how 
this new part compares to the existing parts.

> 
> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>
> ---
>  Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> index ac5f2e0f42cb..b39c76b685f4 100644
> --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml
> @@ -20,6 +20,7 @@ properties:
>        - awinic,aw88395
>        - awinic,aw88261
>        - awinic,aw88399
> +      - awinic,aw88081
>  
>    reg:
>      maxItems: 1
> @@ -57,6 +58,7 @@ allOf:
>            contains:
>              enum:
>                - awinic,aw88261
> +              - awinic,aw88081
>      then:
>        properties:
>          reset-gpios: false
> -- 
> 2.47.0
>