linux-kernel - Re: [PATCH 2/2] platform/x86/intel/pmc: Remove unnecessary ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d72833eb5d89f5f88cb3d40a909411eabba0e2a.camel@linux.intel.com>
Date: Fri, 18 Oct 2024 07:36:29 -0700
From: "David E. Box" <david.e.box@...ux.intel.com>
To: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com, 
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] platform/x86/intel/pmc: Remove unnecessary ioremap

On Thu, 2024-10-17 at 20:03 -0700, David E. Box wrote:
> pmc_get_pmc() unnecessarily calls ioremap to access memory that is already
> available through a variable passed in as an argument. Replace the
> redundant ioremap call with direct use of the provided variable, and remove
> the ioremap and iounmap calls.

Woke up to a test failure on this one. I'll drop in V2 or modify after checking
what I missed.

David

> 
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
>  drivers/platform/x86/intel/pmc/core_ssram.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/pmc/core_ssram.c
> b/drivers/platform/x86/intel/pmc/core_ssram.c
> index 70e03bd53740..d293e6e166e1 100644
> --- a/drivers/platform/x86/intel/pmc/core_ssram.c
> +++ b/drivers/platform/x86/intel/pmc/core_ssram.c
> @@ -171,13 +171,7 @@ pmc_add_pmt(struct pmc_dev *pmcdev, u64 ssram_base, void
> __iomem *ssram)
>  	u32 dvsec_offset;
>  	u32 table, hdr;
>  
> -	ssram = ioremap(ssram_base, SSRAM_HDR_SIZE);
> -	if (!ssram)
> -		return;
> -
>  	dvsec_offset = readl(ssram + SSRAM_DVSEC_OFFSET);
> -	iounmap(ssram);
> -
>  	dvsec = ioremap(ssram_base + dvsec_offset, SSRAM_DVSEC_SIZE);
>  	if (!dvsec)
>  		return;