linux-kernel - Re: [PATCH v3] net: stmmac: allocate separate page for buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8677a11c-8735-43c7-ae5b-6dc894d94677@lunn.ch>
Date: Fri, 18 Oct 2024 04:32:57 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Furong Xu <0x1207@...il.com>
Cc: Suraj Jaiswal <quic_jsuraj@...cinc.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Prasad Sodagudi <psodagud@...cinc.com>,
	Andrew Halaney <ahalaney@...hat.com>, Rob Herring <robh@...nel.org>,
	kernel@...cinc.com
Subject: Re: [PATCH v3] net: stmmac: allocate separate page for buffer

On Thu, Oct 17, 2024 at 07:42:58PM +0800, Furong Xu wrote:
> Hi Suraj,
> 
> Thanks for this fix.
> 
> I tested your patch on XGMAC 3.20a, all goes well, except a performance
> drop of ~10%
> Like Jakub Kicinski said in V2, this involves more dma_map() and does add
> overhead :-/
> 
> I might have a better fix for this, I will send to review and CC it to you.

Lets mark this as changed-requested, due to the performance drop

It also introduces one more kdoc warning.


    Andrew

---
pw-bot: cr