[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <172926481069.1381973.16405989898927387636.b4-ty@kernel.org>
Date: Fri, 18 Oct 2024 08:20:10 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
Kan Liang <kan.liang@...ux.intel.com>, James Clark <james.clark@...aro.org>,
Athira Jajeev <atrajeev@...ux.vnet.ibm.com>,
zhaimingbing <zhaimingbing@...s.chinamobile.com>,
Thomas Richter <tmricht@...ux.ibm.com>,
Veronika Molnarova <vmolnaro@...hat.com>, Leo Yan <leo.yan@...ux.dev>,
Howard Chu <howardchu95@...il.com>, Ze Gao <zegao2021@...il.com>,
Weilin Wang <weilin.wang@...el.com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>,
Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v2 0/3] Make "Setup struct perf_event_attr" a shell
test
On Mon, 14 Oct 2024 17:01:55 -0700, Ian Rogers wrote:
> The path detection for "Setup struct perf_event_attr" test is brittle
> and leads to the test frequently not running. Running shell tests is
> reasonably robust, so make the test a shell test. Move the test files
> to reflect this.
>
> Before, if you build perf like `make -C tools/perf O=/tmp/perf` then
> run the built perf test for the "Setup struct perf_event_attr" it
> skips (causing the tests to bitrot, fixes to be sent, etc.):
> ```
> $ sudo /tmp/perf/perf test -vv perf_event_attr
> capget syscall failed (No such file or directory - 2) fall back on root check
> 17: Setup struct perf_event_attr:
> 17: Setup struct perf_event_attr:
> --- start ---
> test child forked, pid 806601
> Using CPUID GenuineIntel-6-8D-1
> ---- end(-2) ----
> 17: Setup struct perf_event_attr : Skip
> ```
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
Powered by blists - more mailing lists