linux-kernel - Re: [PATCH] mm: Remove unused has_isolate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58eba1ba-c943-4a16-8706-8efde7ee7eb2@collabora.com>
Date: Fri, 18 Oct 2024 20:35:35 +0500
From: Muhammad Usama Anjum <Usama.Anjum@...labora.com>
To: Luoxi Li <kaixa@...oview.com>, linux-mm@...ck.org
Cc: Usama.Anjum@...labora.com, linux-kernel@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>,
 Johannes Weiner <hannes@...xchg.org>, Vlastimil Babka <vbabka@...e.cz>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>
Subject: Re: [PATCH] mm: Remove unused has_isolate_pageblock

On 10/18/24 2:22 PM, Luoxi Li wrote:
> has_isolate_pageblock() has been unused since commit 55612e80e722
> ("mm: page_alloc: close migratetype race between freeing and stealing")
> 
> Remove it.
> 
> Signed-off-by: Luoxi Li <kaixa@...oview.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  include/linux/page-isolation.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h
> index c16db0067090..73dc2c1841ec 100644
> --- a/include/linux/page-isolation.h
> +++ b/include/linux/page-isolation.h
> @@ -3,10 +3,6 @@
>  #define __LINUX_PAGEISOLATION_H
>  
>  #ifdef CONFIG_MEMORY_ISOLATION
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> -	return zone->nr_isolate_pageblock;
> -}
>  static inline bool is_migrate_isolate_page(struct page *page)
>  {
>  	return get_pageblock_migratetype(page) == MIGRATE_ISOLATE;
> @@ -16,10 +12,6 @@ static inline bool is_migrate_isolate(int migratetype)
>  	return migratetype == MIGRATE_ISOLATE;
>  }
>  #else
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> -	return false;
> -}
>  static inline bool is_migrate_isolate_page(struct page *page)
>  {
>  	return false;

-- 
BR,
Muhammad Usama Anjum