linux-kernel - Re: [PATCH V3 1/2] platform/x86/intel/pmc: Refactor platform resume functions to use cnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j0ZG=2chXuAkc2NDp1+-_SKrGx1s0MHyNdr8weNqPbgQ@mail.gmail.com>
Date: Fri, 18 Oct 2024 17:51:28 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: "David E. Box" <david.e.box@...ux.intel.com>
Cc: david.e.box@...el.com, hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com, 
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-pm@...r.kernel.org, rjw@...ysocki.net, 
	srinivas.pandruvada@...ux.intel.com
Subject: Re: [PATCH V3 1/2] platform/x86/intel/pmc: Refactor platform resume
 functions to use cnl_resume()

On Thu, Oct 17, 2024 at 11:04 PM David E. Box
<david.e.box@...ux.intel.com> wrote:
>
> Several platform resume functions currently call pmc_core_send_ltr_ignore()
> and pmc_core_resume_common(), both of which are already called by
> cnl_resume(). Simplify the code by having these functions call cnl_resume()
> directly.
>
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
> V3 - no change
>
> V2 - New patch. Split from V1

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

>
>  drivers/platform/x86/intel/pmc/arl.c | 3 +--
>  drivers/platform/x86/intel/pmc/lnl.c | 3 +--
>  drivers/platform/x86/intel/pmc/mtl.c | 3 +--
>  3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/intel/pmc/arl.c
> index e10527c4e3e0..05dec4f5019f 100644
> --- a/drivers/platform/x86/intel/pmc/arl.c
> +++ b/drivers/platform/x86/intel/pmc/arl.c
> @@ -687,9 +687,8 @@ static void arl_d3_fixup(void)
>  static int arl_resume(struct pmc_dev *pmcdev)
>  {
>         arl_d3_fixup();
> -       pmc_core_send_ltr_ignore(pmcdev, 3, 0);
>
> -       return pmc_core_resume_common(pmcdev);
> +       return cnl_resume(pmcdev);
>  }
>
>  int arl_core_init(struct pmc_dev *pmcdev)
> diff --git a/drivers/platform/x86/intel/pmc/lnl.c b/drivers/platform/x86/intel/pmc/lnl.c
> index e7a8077d1a3e..be029f12cdf4 100644
> --- a/drivers/platform/x86/intel/pmc/lnl.c
> +++ b/drivers/platform/x86/intel/pmc/lnl.c
> @@ -546,9 +546,8 @@ static void lnl_d3_fixup(void)
>  static int lnl_resume(struct pmc_dev *pmcdev)
>  {
>         lnl_d3_fixup();
> -       pmc_core_send_ltr_ignore(pmcdev, 3, 0);
>
> -       return pmc_core_resume_common(pmcdev);
> +       return cnl_resume(pmcdev);
>  }
>
>  int lnl_core_init(struct pmc_dev *pmcdev)
> diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c
> index 91f2fa728f5c..fc6a89b8979f 100644
> --- a/drivers/platform/x86/intel/pmc/mtl.c
> +++ b/drivers/platform/x86/intel/pmc/mtl.c
> @@ -988,9 +988,8 @@ static void mtl_d3_fixup(void)
>  static int mtl_resume(struct pmc_dev *pmcdev)
>  {
>         mtl_d3_fixup();
> -       pmc_core_send_ltr_ignore(pmcdev, 3, 0);
>
> -       return pmc_core_resume_common(pmcdev);
> +       return cnl_resume(pmcdev);
>  }
>
>  int mtl_core_init(struct pmc_dev *pmcdev)
>
> base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
> --
> 2.43.0
>
>