linux-kernel - Re: [PATCH 1/3] PCI: Remove unused PCI_SUBTRACTIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018165842.0000597d@Huawei.com>
Date: Fri, 18 Oct 2024 16:58:42 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Niklas Schnelle <schnelle@...ux.ibm.com>, Gerald Schaefer
	<gerald.schaefer@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>, "Vasily
 Gorbik" <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>, Sven Schnelle
	<svens@...ux.ibm.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Thomas Gleixner
	<tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, Borislav Petkov
	<bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, <x86@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>, <linux-s390@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 1/3] PCI: Remove unused PCI_SUBTRACTIVE_DECODE

On Thu, 17 Oct 2024 17:11:08 +0300
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:

> The commit 2fe2abf896c1 ("PCI: augment bus resource table with a list")
> added PCI_SUBTRACTIVE_DECODE which is put into the struct
> pci_bus_resource flags field but is never read. There seems to never
> have been users for it. Remove both PCI_SUBTRACTIVE_DECODE and the
> flags field from the struct pci_bus_resource.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Nice cleanup.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  arch/s390/pci/pci_bus.c |  2 +-
>  arch/x86/pci/fixup.c    |  2 +-
>  drivers/pci/bus.c       |  4 +---
>  drivers/pci/probe.c     |  5 ++---
>  include/linux/pci.h     | 12 +-----------
>  5 files changed, 6 insertions(+), 19 deletions(-)