linux-kernel - Re: [PATCH v2 2/2] thermal: Add support for Airoha EN7581 thermal sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410182328.IP4meFxF-lkp@intel.com>
Date: Sat, 19 Oct 2024 00:09:29 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Marangi <ansuelsmth@...il.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Lorenzo Bianconi <lorenzo@...nel.org>, upstream@...oha.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev
Subject: Re: [PATCH v2 2/2] thermal: Add support for Airoha EN7581 thermal
 sensor

Hi Christian,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on linus/master v6.12-rc3 next-20241018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/thermal-Add-support-for-Airoha-EN7581-thermal-sensor/20241017-224102
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link:    https://lore.kernel.org/r/20241017143830.1656-2-ansuelsmth%40gmail.com
patch subject: [PATCH v2 2/2] thermal: Add support for Airoha EN7581 thermal sensor
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241018/202410182328.IP4meFxF-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410182328.IP4meFxF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410182328.IP4meFxF-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/thermal/airoha_thermal.c:239:39: error: incomplete definition of type 'struct thermal_zone_device'
     239 |         struct airoha_thermal_priv *priv = tz->devdata;
         |                                            ~~^
   include/linux/thermal.h:32:8: note: forward declaration of 'struct thermal_zone_device'
      32 | struct thermal_zone_device;
         |        ^
   drivers/thermal/airoha_thermal.c:268:39: error: incomplete definition of type 'struct thermal_zone_device'
     268 |         struct airoha_thermal_priv *priv = tz->devdata;
         |                                            ~~^
   include/linux/thermal.h:32:8: note: forward declaration of 'struct thermal_zone_device'
      32 | struct thermal_zone_device;
         |        ^
   drivers/thermal/airoha_thermal.c:466:10: error: incomplete definition of type 'struct thermal_zone_device'
     466 |         priv->tz->tzp->offset = priv->default_offset;
         |         ~~~~~~~~^
   include/linux/thermal.h:32:8: note: forward declaration of 'struct thermal_zone_device'
      32 | struct thermal_zone_device;
         |        ^
   drivers/thermal/airoha_thermal.c:467:10: error: incomplete definition of type 'struct thermal_zone_device'
     467 |         priv->tz->tzp->slope = priv->default_slope;
         |         ~~~~~~~~^
   include/linux/thermal.h:32:8: note: forward declaration of 'struct thermal_zone_device'
      32 | struct thermal_zone_device;
         |        ^
   4 errors generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MODVERSIONS
   Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y]
   Selected by [y]:
   - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y]


vim +239 drivers/thermal/airoha_thermal.c

   236	
   237	static int airoha_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
   238	{
 > 239		struct airoha_thermal_priv *priv = tz->devdata;
   240		int min, max, avg_temp, temp_adc;
   241		int i;
   242	
   243		/* Get the starting temp */
   244		temp_adc = airoha_get_thermal_ADC(priv);
   245		min = temp_adc;
   246		max = temp_adc;
   247		avg_temp = temp_adc;
   248	
   249		/* Make 5 more measurement and average the temp ADC difference */
   250		for (i = 0; i < 5; i++) {
   251			temp_adc = airoha_get_thermal_ADC(priv);
   252			avg_temp += temp_adc;
   253			if (temp_adc > max)
   254				max = temp_adc;
   255			if (temp_adc < min)
   256				min = temp_adc;
   257		}
   258		avg_temp = avg_temp - max - min;
   259		avg_temp /= 4;
   260	
   261		*temp = RAW_TO_TEMP(priv, avg_temp);
   262		return 0;
   263	}
   264	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki