linux-kernel - Re: [PATCH] netfliter: xtables: fix typo causing some targets to not load on IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxKJe9sPze2mEJvF@orbyte.nwl.cc>
Date: Fri, 18 Oct 2024 18:14:51 +0200
From: Phil Sutter <phil@....cc>
To: Ilya Katsnelson <me@...ti.me>
Cc: Pablo Neira Ayuso <pablo@...filter.org>,
	Jozsef Kadlecsik <kadlec@...filter.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Florian Westphal <fw@...len.de>, Sasha Levin <sashal@...nel.org>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfliter: xtables: fix typo causing some targets to not
 load on IPv6

On Fri, Oct 18, 2024 at 06:45:00PM +0300, Ilya Katsnelson wrote:
> These were added with the wrong family in 4cdc55e, which seems
> to just have been a typo, but now ip6tables rules with --set-mark
> don't work anymore, which is pretty bad.
> 
> Fixes: 4cdc55ec6222 ("netfilter: xtables: avoid NFPROTO_UNSPEC where needed")

On my system, the commit is 0bfcb7b71e735560077a42847f69597ec7dcc326. Is
that correct?

> Signed-off-by: Ilya Katsnelson <me@...ti.me>

Reviewed-by: Phil Sutter <phil@....cc>