| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <bdd2a873-3d5b-4986-a79c-d2bb54997b43@quicinc.com>
Date: Fri, 18 Oct 2024 23:14:00 +0530
From: Taniya Das <quic_tdas@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
Michael Turquette
<mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>, Rob Herring
<robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Ajit Pandey <quic_ajipan@...cinc.com>,
Imran Shaik
<quic_imrashai@...cinc.com>,
Jagadeesh Kona <quic_jkona@...cinc.com>,
<linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] clk: qcom: gcc: Add support for QCS615 GCC clocks
On 10/16/2024 3:46 PM, Dmitry Baryshkov wrote:
> On Wed, Oct 16, 2024 at 09:40:07AM +0530, Taniya Das wrote:
>>
>>
>> On 9/20/2024 4:33 PM, Dmitry Baryshkov wrote:
>>> On Fri, Sep 20, 2024 at 04:08:18PM GMT, Taniya Das wrote:
>>>> Add the global clock controller support for QCS615 SoC.
>>>>
>>>> Signed-off-by: Taniya Das <quic_tdas@...cinc.com>
>>>> ---
>>>> drivers/clk/qcom/Kconfig | 9 +
>>>> drivers/clk/qcom/Makefile | 1 +
>>>> drivers/clk/qcom/gcc-qcs615.c | 3035 +++++++++++++++++++++++++++++++++++++++++
>>>> 3 files changed, 3045 insertions(+)
>>>> +};
>>>> +
>>>> +static struct clk_alpha_pll gpll0 = {
>>>> + .offset = 0x0,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr = {
>>>> + .enable_reg = 0x52000,
>>>> + .enable_mask = BIT(0),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll0",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .index = DT_BI_TCXO,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_fixed_factor gpll0_out_aux2_div = {
>>>> + .mult = 1,
>>>> + .div = 2,
>>>> + .hw.init = &(struct clk_init_data) {
>>>> + .name = "gpll0_out_aux2_div",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .hw = &gpll0.clkr.hw,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_fixed_factor_ops,
>>>> + },
>>>> +};
>>>
>>> Should it be clk_alpha_pll_postdiv_foo_ops ?
>>>
>>
>> This is not the PLL output, but it is a fixed divider which is placed as
>> input to the RCG.
>> That is the reason to use the fixed factor.
>
> Usually OUT_AUX2 is the PLL output, isn't it? Even by its name. See
> gcc-qcm2290 / gcc-sm6115 and most of other clock controller drivers,
> except gcc-sm6125. Maybe I don't understand the difference between the
> two usecases. Is there a difference in the GCC / PLL design?
>
Yes, your understanding is correct out_aux2/out_main are the PLL leaf
outputs. But on QCS615 the PLL dividers are not used and thus the aux2
and the other leaf outputs are at the same frequency as the main output
of the VCO and instead there was a fixed divider placed after the PLL to
divide the VCO output. There was a GCC design change required to meet
timing closures.
>>>> +
>>>> +static struct clk_alpha_pll gpll3 = {
>>>> + .offset = 0x3000,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr = {
>>>> + .enable_reg = 0x52000,
>>>> + .enable_mask = BIT(3),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll3",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .index = DT_BI_TCXO,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_fixed_factor gpll3_out_aux2_div = {
>>>> + .mult = 1,
>>>> + .div = 2,
>>>> + .hw.init = &(struct clk_init_data) {
>>>> + .name = "gpll3_out_aux2_div",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .hw = &gpll3.clkr.hw,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_fixed_factor_ops,
>>>> + },
>>>> +};
>>>
>>> Should it be clk_alpha_pll_postdiv_foo_ops ?
>>>
>>
>> Same is the case here as well. This is not the PLL output, but it is a fixed
>> divider which is placed as input to the RCG.
>> That is the reason to use the fixed factor.
>>
>>>> +
>>>> +static struct clk_alpha_pll gpll4 = {
>>>> + .offset = 0x76000,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr = {
>>>> + .enable_reg = 0x52000,
>>>> + .enable_mask = BIT(4),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll4",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .index = DT_BI_TCXO,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_alpha_pll gpll6 = {
>>>> + .offset = 0x13000,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr = {
>>>> + .enable_reg = 0x52000,
>>>> + .enable_mask = BIT(6),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll6",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .index = DT_BI_TCXO,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct clk_div_table post_div_table_gpll6_out_main[] = {
>>>> + { 0x1, 2 },
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_alpha_pll_postdiv gpll6_out_main = {
>>>> + .offset = 0x13000,
>>>> + .post_div_shift = 8,
>>>> + .post_div_table = post_div_table_gpll6_out_main,
>>>> + .num_post_div = ARRAY_SIZE(post_div_table_gpll6_out_main),
>>>> + .width = 4,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll6_out_main",
>>>> + .parent_hws = (const struct clk_hw*[]) {
>>>> + &gpll6.clkr.hw,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_postdiv_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_alpha_pll gpll7 = {
>>>> + .offset = 0x1a000,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr = {
>>>> + .enable_reg = 0x52000,
>>>> + .enable_mask = BIT(7),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll7",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .index = DT_BI_TCXO,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_alpha_pll gpll8 = {
>>>> + .offset = 0x1b000,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr = {
>>>> + .enable_reg = 0x52000,
>>>> + .enable_mask = BIT(8),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll8",
>>>> + .parent_data = &(const struct clk_parent_data) {
>>>> + .index = DT_BI_TCXO,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct clk_div_table post_div_table_gpll8_out_main[] = {
>>>> + { 0x1, 2 },
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_alpha_pll_postdiv gpll8_out_main = {
>>>> + .offset = 0x1b000,
>>>> + .post_div_shift = 8,
>>>> + .post_div_table = post_div_table_gpll8_out_main,
>>>> + .num_post_div = ARRAY_SIZE(post_div_table_gpll8_out_main),
>>>> + .width = 4,
>>>> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_DEFAULT],
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gpll8_out_main",
>>>> + .parent_hws = (const struct clk_hw*[]) {
>>>> + &gpll8.clkr.hw,
>>>> + },
>>>> + .num_parents = 1,
>>>> + .ops = &clk_alpha_pll_postdiv_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_0[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_0[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_0_ao[] = {
>>>> + { .index = DT_BI_TCXO_AO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_1[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL6_OUT_MAIN, 2 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_1[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll6_out_main.clkr.hw },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_2[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_SLEEP_CLK, 5 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_2[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .index = DT_SLEEP_CLK },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_3[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_SLEEP_CLK, 5 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_3[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .index = DT_SLEEP_CLK },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_4[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_4[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_5[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL7_OUT_MAIN, 3 },
>>>> + { P_GPLL4_OUT_MAIN, 5 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_5[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll7.clkr.hw },
>>>> + { .hw = &gpll4.clkr.hw },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_6[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL7_OUT_MAIN, 3 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_6[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll7.clkr.hw },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_7[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL3_OUT_MAIN_DIV, 4 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_7[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll3_out_aux2_div.hw },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_8[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL8_OUT_MAIN, 2 },
>>>> + { P_GPLL4_OUT_MAIN, 5 },
>>>> + { P_GPLL0_OUT_AUX2_DIV, 6 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_8[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll8_out_main.clkr.hw },
>>>> + { .hw = &gpll4.clkr.hw },
>>>> + { .hw = &gpll0_out_aux2_div.hw },
>>>> +};
>>>> +
>>>> +static const struct parent_map gcc_parent_map_9[] = {
>>>> + { P_BI_TCXO, 0 },
>>>> + { P_GPLL0_OUT_MAIN, 1 },
>>>> + { P_GPLL3_OUT_MAIN, 4 },
>>>> +};
>>>> +
>>>> +static const struct clk_parent_data gcc_parent_data_9[] = {
>>>> + { .index = DT_BI_TCXO },
>>>> + { .hw = &gpll0.clkr.hw },
>>>> + { .hw = &gpll3.clkr.hw },
>>>> +};
>>>> +
>>>> +static const struct freq_tbl ftbl_gcc_cpuss_ahb_clk_src[] = {
>>>> + F(19200000, P_BI_TCXO, 1, 0, 0),
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_cpuss_ahb_clk_src = {
>>>> + .cmd_rcgr = 0x48014,
>>>> + .mnd_width = 0,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_0,
>>>> + .freq_tbl = ftbl_gcc_cpuss_ahb_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_cpuss_ahb_clk_src",
>>>> + .parent_data = gcc_parent_data_0_ao,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_0_ao),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct freq_tbl ftbl_gcc_emac_ptp_clk_src[] = {
>>>> + F(19200000, P_BI_TCXO, 1, 0, 0),
>>>> + F(50000000, P_GPLL0_OUT_AUX2_DIV, 6, 0, 0),
>>>> + F(75000000, P_GPLL0_OUT_AUX2_DIV, 4, 0, 0),
>>>> + F(125000000, P_GPLL7_OUT_MAIN, 4, 0, 0),
>>>> + F(250000000, P_GPLL7_OUT_MAIN, 2, 0, 0),
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_emac_ptp_clk_src = {
>>>> + .cmd_rcgr = 0x6038,
>>>> + .mnd_width = 0,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_5,
>>>> + .freq_tbl = ftbl_gcc_emac_ptp_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_emac_ptp_clk_src",
>>>> + .parent_data = gcc_parent_data_5,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_5),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct freq_tbl ftbl_gcc_emac_rgmii_clk_src[] = {
>>>> + F(2500000, P_BI_TCXO, 1, 25, 192),
>>>> + F(5000000, P_BI_TCXO, 1, 25, 96),
>>>> + F(19200000, P_BI_TCXO, 1, 0, 0),
>>>> + F(25000000, P_GPLL0_OUT_AUX2_DIV, 12, 0, 0),
>>>> + F(50000000, P_GPLL0_OUT_AUX2_DIV, 6, 0, 0),
>>>> + F(75000000, P_GPLL0_OUT_AUX2_DIV, 4, 0, 0),
>>>> + F(125000000, P_GPLL7_OUT_MAIN, 4, 0, 0),
>>>> + F(250000000, P_GPLL7_OUT_MAIN, 2, 0, 0),
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_emac_rgmii_clk_src = {
>>>> + .cmd_rcgr = 0x601c,
>>>> + .mnd_width = 8,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_6,
>>>> + .freq_tbl = ftbl_gcc_emac_rgmii_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_emac_rgmii_clk_src",
>>>> + .parent_data = gcc_parent_data_6,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_6),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct freq_tbl ftbl_gcc_gp1_clk_src[] = {
>>>> + F(25000000, P_GPLL0_OUT_AUX2_DIV, 12, 0, 0),
>>>> + F(50000000, P_GPLL0_OUT_AUX2_DIV, 6, 0, 0),
>>>> + F(100000000, P_GPLL0_OUT_MAIN, 6, 0, 0),
>>>> + F(200000000, P_GPLL0_OUT_MAIN, 3, 0, 0),
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_gp1_clk_src = {
>>>> + .cmd_rcgr = 0x64004,
>>>> + .mnd_width = 8,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_2,
>>>> + .freq_tbl = ftbl_gcc_gp1_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_gp1_clk_src",
>>>> + .parent_data = gcc_parent_data_2,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_2),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_gp2_clk_src = {
>>>> + .cmd_rcgr = 0x65004,
>>>> + .mnd_width = 8,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_2,
>>>> + .freq_tbl = ftbl_gcc_gp1_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_gp2_clk_src",
>>>> + .parent_data = gcc_parent_data_2,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_2),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_gp3_clk_src = {
>>>> + .cmd_rcgr = 0x66004,
>>>> + .mnd_width = 8,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_2,
>>>> + .freq_tbl = ftbl_gcc_gp1_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_gp3_clk_src",
>>>> + .parent_data = gcc_parent_data_2,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_2),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +static const struct freq_tbl ftbl_gcc_pcie_0_aux_clk_src[] = {
>>>> + F(9600000, P_BI_TCXO, 2, 0, 0),
>>>> + F(19200000, P_BI_TCXO, 1, 0, 0),
>>>> + { }
>>>> +};
>>>> +
>>>> +static struct clk_rcg2 gcc_pcie_0_aux_clk_src = {
>>>> + .cmd_rcgr = 0x6b02c,
>>>> + .mnd_width = 16,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_3,
>>>> + .freq_tbl = ftbl_gcc_pcie_0_aux_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_pcie_0_aux_clk_src",
>>>> + .parent_data = gcc_parent_data_3,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_3),
>>>> + .ops = &clk_rcg2_ops,
>>>
>>> Should it be using shared ops?
>>> I think there are other clocks here which are usually
>>> clk_rcg2_shared_ops.
>>>
>>
>> As the source frequency is derived from 19.2MHz, so I left it as the normal
>> RCG ops. I can update it in the next patch.
>>
>>>> + },
>>>> +};
>>>> +
>>>
>>> [...]
>>>
>>>> +static struct clk_rcg2 gcc_vsensor_clk_src = {
>>>> + .cmd_rcgr = 0x7a018,
>>>> + .mnd_width = 0,
>>>> + .hid_width = 5,
>>>> + .parent_map = gcc_parent_map_9,
>>>> + .freq_tbl = ftbl_gcc_vsensor_clk_src,
>>>> + .clkr.hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_vsensor_clk_src",
>>>> + .parent_data = gcc_parent_data_9,
>>>> + .num_parents = ARRAY_SIZE(gcc_parent_data_9),
>>>> + .ops = &clk_rcg2_ops,
>>>> + },
>>>> +};
>>>> +
>>>> +
>>>
>>> Extra empty line
>>>
>> Sure, will take care in the next patch.
>>
>>
>>>> +static struct clk_branch gcc_aggre_ufs_phy_axi_clk = {
>>>> + .halt_reg = 0x770c0,
>>>> + .halt_check = BRANCH_HALT_VOTED,
>>>
>>> [...]
>>>
>>>> +
>>>> +static struct clk_branch gcc_pcie_0_pipe_clk = {
>>>> + .halt_reg = 0x6b024,
>>>> + .halt_check = BRANCH_HALT_SKIP,
>>>> + .clkr = {
>>>> + .enable_reg = 0x5200c,
>>>> + .enable_mask = BIT(4),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_pcie_0_pipe_clk",
>>>> + .ops = &clk_branch2_ops,
>>>> + },
>>>> + },
>>>> +};
>>>
>>> No corresponding gcc_pcie_0_pipe_clk_src?
>>>
>>
>> On QCS615 the pipe clock source is not required to be modelled as the mux is
>> default Power on reset is set to external pipe clock.
>
> And do we need to toggle the source of the clk_src together with the
> GDSC toggling?
>
AFAIR, QCS615 didn't require toggling for GDSC, as even on downstream
kernel we do not have the pipe_clk_src modelled in our driver.
>>
>>>> +
>>>> +static struct clk_branch gcc_pcie_0_slv_axi_clk = {
>>>> + .halt_reg = 0x6b014,
>>>> + .halt_check = BRANCH_HALT_VOTED,
>>>> + .hwcg_reg = 0x6b014,
>>>> + .hwcg_bit = 1,
>>>> + .clkr = {
>>>> + .enable_reg = 0x5200c,
>>>> + .enable_mask = BIT(0),
>>>> + .hw.init = &(const struct clk_init_data) {
>>>> + .name = "gcc_pcie_0_slv_axi_clk",
>>>> + .ops = &clk_branch2_ops,
>>>> + },
>>>> + },
>>>> +};
>>>> +
>>>
>>> [...]
>>>
>>
>> --
>> Thanks & Regards,
>> Taniya Das.
>
--
Thanks & Regards,
Taniya Das.
Powered by blists - more mailing lists