[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241018033500.13833-1-gouhao@uniontech.com>
Date: Fri, 18 Oct 2024 11:35:00 +0800
From: Gou Hao <gouhao@...ontech.com>
To: xiang@...nel.org,
chao@...nel.org
Cc: linux-erofs@...ts.ozlabs.org,
linux-kernel@...r.kernel.org,
gouhaojake@....com
Subject: [PATCH] erofs: simplify definition of the log functions
using printk instead of pr_info/err, reduce
redundant code.
Signed-off-by: Gou Hao <gouhao@...ontech.com>
---
fs/erofs/internal.h | 9 ++++-----
fs/erofs/super.c | 28 +++++++---------------------
2 files changed, 11 insertions(+), 26 deletions(-)
diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
index 4efd578d7c62..ae87e855e815 100644
--- a/fs/erofs/internal.h
+++ b/fs/erofs/internal.h
@@ -24,14 +24,13 @@
#undef pr_fmt
#define pr_fmt(fmt) "erofs: " fmt
-__printf(3, 4) void _erofs_err(struct super_block *sb,
+__printf(3, 4) void _erofs_printk(struct super_block *sb,
const char *function, const char *fmt, ...);
#define erofs_err(sb, fmt, ...) \
- _erofs_err(sb, __func__, fmt "\n", ##__VA_ARGS__)
-__printf(3, 4) void _erofs_info(struct super_block *sb,
- const char *function, const char *fmt, ...);
+ _erofs_printk(sb, __func__, KERN_ERR fmt "\n", ##__VA_ARGS__)
#define erofs_info(sb, fmt, ...) \
- _erofs_info(sb, __func__, fmt "\n", ##__VA_ARGS__)
+ _erofs_printk(sb, __func__, KERN_INFO fmt "\n", ##__VA_ARGS__)
+
#ifdef CONFIG_EROFS_FS_DEBUG
#define DBG_BUGON BUG_ON
#else
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 666873f745da..64c3258ddf9a 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -18,37 +18,23 @@
static struct kmem_cache *erofs_inode_cachep __read_mostly;
-void _erofs_err(struct super_block *sb, const char *func, const char *fmt, ...)
+void _erofs_printk(struct super_block *sb, const char *func, const char *fmt, ...)
{
struct va_format vaf;
va_list args;
+ int level;
va_start(args, fmt);
- vaf.fmt = fmt;
+ level = printk_get_level(fmt);
+ vaf.fmt = printk_skip_level(fmt);
vaf.va = &args;
if (sb)
- pr_err("(device %s): %s: %pV", sb->s_id, func, &vaf);
+ printk("%c%c(device %s): %s: %pV",
+ KERN_SOH_ASCII, level, sb->s_id, func, &vaf);
else
- pr_err("%s: %pV", func, &vaf);
- va_end(args);
-}
-
-void _erofs_info(struct super_block *sb, const char *func, const char *fmt, ...)
-{
- struct va_format vaf;
- va_list args;
-
- va_start(args, fmt);
-
- vaf.fmt = fmt;
- vaf.va = &args;
-
- if (sb)
- pr_info("(device %s): %pV", sb->s_id, &vaf);
- else
- pr_info("%pV", &vaf);
+ printk("%c%c%s: %pV", KERN_SOH_ASCII, level, func, &vaf);
va_end(args);
}
--
2.43.0
Powered by blists - more mailing lists