linux-kernel - Re: [PATCH net-next v1 4/5] net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241018191603.GA1697@kernel.org>
Date: Fri, 18 Oct 2024 20:16:03 +0100
From: Simon Horman <horms@...nel.org>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Furong Xu <0x1207@...il.com>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Andrew Lunn <andrew@...n.ch>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, xfr@...look.com
Subject: Re: [PATCH net-next v1 4/5] net: stmmac: xgmac: Rename XGMAC_RQ to
 XGMAC_FPRQ

On Thu, Oct 17, 2024 at 08:18:52PM +0300, Vladimir Oltean wrote:
> On Tue, Oct 15, 2024 at 05:09:25PM +0800, Furong Xu wrote:
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > index 917796293c26..c66fa6040672 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> > @@ -84,8 +84,8 @@
> >  #define XGMAC_MCBCQEN			BIT(15)
> >  #define XGMAC_MCBCQ			GENMASK(11, 8)
> >  #define XGMAC_MCBCQ_SHIFT		8
> > -#define XGMAC_RQ			GENMASK(7, 4)
> > -#define XGMAC_RQ_SHIFT			4
> > +#define XGMAC_FPRQ			GENMASK(7, 4)
> > +#define XGMAC_FPRQ_SHIFT		4
> 
> If you made use of FIELD_PREP(), you would not need the _SHIFT variant at all
> (though that would be a separate logical change).

+1

> >  #define XGMAC_UPQ			GENMASK(3, 0)
> >  #define XGMAC_UPQ_SHIFT			0
> >  #define XGMAC_RXQ_CTRL2			0x000000a8
>