[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <940da07b-1286-4b88-8384-16ca2f996d90@oss.qualcomm.com>
Date: Fri, 18 Oct 2024 21:58:11 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>, ath12k@...ts.infradead.org
Cc: linux-wireless@...r.kernel.org, Kalle Valo <kvalo@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
P Praneesh <quic_ppranees@...cinc.com>,
Balamurugan S <quic_bselvara@...cinc.com>
Subject: Re: [PATCH v2 05/22] wifi: ath12k: add ath12k_hw_regs for IPQ5332
On 15.10.2024 8:26 PM, Raj Kumar Bhagat wrote:
> From: P Praneesh <quic_ppranees@...cinc.com>
>
> Add register addresses (ath12k_hw_regs) for new ath12k AHB based
> WiFi device IPQ5332.
>
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: P Praneesh <quic_ppranees@...cinc.com>
> Co-developed-by: Balamurugan S <quic_bselvara@...cinc.com>
> Signed-off-by: Balamurugan S <quic_bselvara@...cinc.com>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
> ---
[...]
> + /* CE base address */
> + .hal_umac_ce0_src_reg_base = 0x00740000,
> + .hal_umac_ce0_dest_reg_base = 0x00741000,
> + .hal_umac_ce1_src_reg_base = 0x00742000,
> + .hal_umac_ce1_dest_reg_base = 0x00743000,
> +};
> +
> static const struct ath12k_hw_regs wcn7850_regs = {
> /* SW2TCL(x) R0 ring configuration address */
> .hal_tcl1_ring_id = 0x00000908,
> @@ -1126,7 +1210,7 @@ static const struct ath12k_hw_params ath12k_hw_params[] = {
> .internal_sleep_clock = false,
>
> .hw_ops = &qcn9274_ops,
> - .regs = NULL,
> + .regs = &ipq5332_regs,
This makes me believe the patches should be reordered (or perhaps
this should be squashed with "add ath12k_hw_params for IPQ5332"?)
Konrad
Powered by blists - more mailing lists