linux-kernel - Re: [PATCH 0/3] nfsd: fix final setattr on delegated timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172928353196.235979.12559359835670760311.b4-ty@oracle.com>
Date: Fri, 18 Oct 2024 16:32:40 -0400
From: cel@...nel.org
To: Neil Brown <neilb@...e.de>,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>,
	Tom Talpey <tom@...pey.com>,
	Jeff Layton <jlayton@...nel.org>
Cc: Chuck Lever <chuck.lever@...cle.com>,
	linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Olga Kornievskaia <aglo@...ch.edu>
Subject: Re: [PATCH 0/3] nfsd: fix final setattr on delegated timestamps

From: Chuck Lever <chuck.lever@...cle.com>

On Fri, 18 Oct 2024 14:44:58 -0400, Jeff Layton wrote:                                              
> Olga reported seeing a NFS4ERR_INVAL return on the final SETATTR before
> a DELEGRETURN to set the timestamps. The first patch fixes that by
> simply ensuring they are declared writeable. The second patch fixes a
> related bug in the stateid handling in that same SETATTR. The last patch
> adds a new tracepoint that I found useful for tracking this down.
> 
> It might be best to squash the first two patches into this one:
> 
> [...]                                                                        

Applied to nfsd-next for v6.13, thanks!                                                                

[1/3] nfsd: add TIME_DELEG_ACCESS and TIME_DELEG_MODIFY to writeable attrs
      (no commit info)
[2/3] nfsd: allow SETATTR to provide a READ deleg for updating time_access
      (no commit info)
[3/3] nfsd: new tracepoint for after op_func in compound processing
      commit: ba6b3220066fdbd38063230cfc7951b728f15464                                                                      

--                                                                              
Chuck Lever