linux-kernel - Re: [PATCH] dax: delete a stale directory pmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6712ca0c1447d_44de62943b@iweiny-mobl.notmuch>
Date: Fri, 18 Oct 2024 15:50:20 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>, Dan Williams
	<dan.j.williams@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Dave
 Jiang" <dave.jiang@...el.com>, Jane Chu <jane.chu@...cle.com>, Dave Hansen
	<dave.hansen@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
	<nvdimm@...ts.linux.dev>, <linux-cxl@...r.kernel.org>
CC: Vegard Nossum <vegard.nossum@...cle.com>
Subject: Re: [PATCH] dax: delete a stale directory pmem

Harshit Mogalapalli wrote:
> After commit: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT") the pmem/
> directory is not needed anymore and Makefile changes were made
> accordingly in this commit, but there is a Makefile and pmem.c in pmem/
> which are now stale and pmem.c is empty, remove them.
> 
> Fixes: 83762cb5c7c4 ("dax: Kill DEV_DAX_PMEM_COMPAT")
> Suggested-by: Vegard Nossum <vegard.nossum@...cle.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>

Marked for nvdimm-next
Thanks!

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> ---
>  drivers/dax/pmem/Makefile |  7 -------
>  drivers/dax/pmem/pmem.c   | 10 ----------
>  2 files changed, 17 deletions(-)
>  delete mode 100644 drivers/dax/pmem/Makefile
>  delete mode 100644 drivers/dax/pmem/pmem.c
> 
> diff --git a/drivers/dax/pmem/Makefile b/drivers/dax/pmem/Makefile
> deleted file mode 100644
> index 191c31f0d4f0..000000000000
> --- a/drivers/dax/pmem/Makefile
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0-only
> -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem.o
> -obj-$(CONFIG_DEV_DAX_PMEM) += dax_pmem_core.o
> -
> -dax_pmem-y := pmem.o
> -dax_pmem_core-y := core.o
> -dax_pmem_compat-y := compat.o
> diff --git a/drivers/dax/pmem/pmem.c b/drivers/dax/pmem/pmem.c
> deleted file mode 100644
> index dfe91a2990fe..000000000000
> --- a/drivers/dax/pmem/pmem.c
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -/* Copyright(c) 2016 - 2018 Intel Corporation. All rights reserved. */
> -#include <linux/percpu-refcount.h>
> -#include <linux/memremap.h>
> -#include <linux/module.h>
> -#include <linux/pfn_t.h>
> -#include <linux/nd.h>
> -#include "../bus.h"
> -
> -
> -- 
> 2.46.0
> 
>