linux-kernel - Re: [PATCH] rcu/srcutiny: don't return before reenabling preemption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZxLOut9zT_pfBWAO@pavilion.home>
Date: Fri, 18 Oct 2024 23:10:18 +0200
From: Frederic Weisbecker <frederic@...nel.org>
To: "Paul E. McKenney" <paulmck@...nel.org>
Cc: Michal Schmidt <mschmidt@...hat.com>,
	Lai Jiangshan <jiangshanlai@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	"Uladzislau Rezki (Sony)" <urezki@...il.com>, rcu@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu/srcutiny: don't return before reenabling preemption

Le Wed, Oct 09, 2024 at 10:19:01AM -0700, Paul E. McKenney a écrit :
> On Mon, Oct 07, 2024 at 12:14:15PM +0200, Michal Schmidt wrote:
> > Code after the return statement is dead. Enable preemption before
> > returning from srcu_drive_gp().
> > 
> > This will be important when/if PREEMPT_AUTO (lazy resched) gets merged.
> > 
> > Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption")
> > Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> 
> Good catch!
> 
> Reviewed-by: Paul E. McKenney <paulmck@...nel.org>

Applied!

Thanks.