linux-kernel - Re: [PATCH] 9p: Avoid creating multiple slab caches with the same name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6852c2d-3371-47a4-bfeb-049f4048e88a@suse.cz>
Date: Fri, 18 Oct 2024 23:38:04 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Thorsten Leemhuis <regressions@...mhuis.info>,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Dominique Martinet <asmadeus@...ewreck.org>
Cc: Eric Van Hensbergen <ericvh@...nel.org>,
 Christian Schoenebeck <linux_oss@...debyte.com>, v9fs@...ts.linux.dev,
 linux-kernel@...r.kernel.org, regressions@...ts.linux.dev,
 Jason Gunthorpe <jgg@...dia.com>, Pedro Falcato <pedro.falcato@...il.com>
Subject: Re: [PATCH] 9p: Avoid creating multiple slab caches with the same
 name

On 10/18/24 8:54 PM, Thorsten Leemhuis wrote:
> [reinserting a bit of quotation below for Linus]
> 
> TLDR: Linus, I wonder if it would be best if you could merge the patch
> at the start of this thread
> (https://lore.kernel.org/all/20240807094725.2193423-1-pedro.falcato@gmail.com/
> ), which can also be found as 79efebae4afc22 in -next if you prefer to
> cherry-pick it from there. Either now or after 24 to 36 hours, which
> would give Eric a chance to ACK/NACK this if he sees this mail.
> 
> For details see below.
> 
> On 18.10.24 20:36, Pedro Falcato wrote:
>> On Fri, Oct 18, 2024 at 6:28 PM Jason Gunthorpe <jgg@...dia.com> wrote:
>>>
>>> On Wed, Aug 07, 2024 at 10:47:25AM +0100, Pedro Falcato wrote:
>>>> In the spirit of [1], avoid creating multiple slab caches with the same
>>>> name. Instead, add the dev_name into the mix.
>>>>
>>>> [1]: https://lore.kernel.org/all/20240807090746.2146479-1-pedro.falcato@gmail.com/
>>>>
>>>> Signed-off-by: Pedro Falcato <pedro.falcato@...il.com>
>>>> ---
>>>>  net/9p/client.c | 10 +++++++++-
>>>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>>
>>> Can this get picked up to rc4 please?
> 
> Eric apparently has not much time or upstream work currently (but
> recently showed up in a discussion about another regression:
> https://lore.kernel.org/all/Zw-J0DdrCFLYpT5y@codewreck.org/ ).
> 
>>> It is causing regressions in my environment
>>> #regzbot introduced: 4c39529663b9
> 
> If anyone wonders, that is 4c39529663b931 ("slab: Warn on duplicate
> cache names when DEBUG_VM=y") [v6.12-rc1]. That's also why I'm CCing
> Vlastimil, so he knows about this.
> 
>> FWIW, seems to have been picked up into 9pfs-next
>> (https://github.com/martinetd/linux/commit/79efebae4afc2221fa814c3cae001bede66ab259).
>> Seems like we're just missing a PR to Linus?

If was Dominique, not Eric, see:
https://lore.kernel.org/all/ZvBIl8b9RRK9jgtJ@codewreck.org/

Can you send it as mentioned in the email? :)

> In that case: Linus, given the circumstances I wonder if it would be
> best if you could merge the patch at the start of this thread
> (https://lore.kernel.org/all/20240807094725.2193423-1-pedro.falcato@gmail.com/
> ) directly, which can also be found as 79efebae4afc22 in -next if you
> prefer to cherry-pick it from there  Either now or after 24 to 36 hours,
> which would give Eric a chance to ACK/NACK this if he sees this mail.
> 
> Ciao, Thorsten