| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202410190549.hGAfByqg-lkp@intel.com>
Date: Sat, 19 Oct 2024 06:11:15 +0800
From: kernel test robot <lkp@...el.com>
To: Jyothi Kumar Seerapu <quic_jseerapu@...cinc.com>,
Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Andi Shyti <andi.shyti@...nel.org>,
Sumit Semwal <sumit.semwal@...aro.org>,
Christian König <christian.koenig@....com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
linaro-mm-sig@...ts.linaro.org, quic_msavaliy@...cinc.com,
quic_vtanuku@...cinc.com
Subject: Re: [PATCH v1 5/5] i2c: i2c-qcom-geni: Add Block event interrupt
support
Hi Jyothi,
kernel test robot noticed the following build errors:
[auto build test ERROR on 55bcd2e0d04c1171d382badef1def1fd04ef66c5]
url: https://github.com/intel-lab-lkp/linux/commits/Jyothi-Kumar-Seerapu/dt-bindings-dmaengine-qcom-gpi-Add-additional-arg-to-dma-cell-property/20241015-202637
base: 55bcd2e0d04c1171d382badef1def1fd04ef66c5
patch link: https://lore.kernel.org/r/20241015120750.21217-6-quic_jseerapu%40quicinc.com
patch subject: [PATCH v1 5/5] i2c: i2c-qcom-geni: Add Block event interrupt support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241019/202410190549.hGAfByqg-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410190549.hGAfByqg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410190549.hGAfByqg-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/i2c/busses/i2c-qcom-geni.c:562:8: error: incompatible pointer to integer conversion passing 'dma_addr_t *' (aka 'unsigned long long *') to parameter of type 'dma_addr_t' (aka 'unsigned long long'); dereference with * [-Wint-conversion]
562 | tx_multi_xfer->dma_addr[wr_idx], NULL, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| *
drivers/i2c/busses/i2c-qcom-geni.c:519:36: note: passing argument to parameter 'tx_addr' here
519 | void *tx_buf, dma_addr_t tx_addr,
| ^
>> drivers/i2c/busses/i2c-qcom-geni.c:562:47: error: incompatible pointer to integer conversion passing 'void *' to parameter of type 'dma_addr_t' (aka 'unsigned long long') [-Wint-conversion]
562 | tx_multi_xfer->dma_addr[wr_idx], NULL, NULL);
| ^~~~
include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
8 | #define NULL ((void *)0)
| ^~~~~~~~~~~
drivers/i2c/busses/i2c-qcom-geni.c:520:36: note: passing argument to parameter 'rx_addr' here
520 | void *rx_buf, dma_addr_t rx_addr)
| ^
>> drivers/i2c/busses/i2c-qcom-geni.c:586:7: error: incompatible pointer to integer conversion assigning to 'dma_addr_t' (aka 'unsigned long long') from 'dma_addr_t *' (aka 'unsigned long long *'); dereference with * [-Wint-conversion]
586 | addr = gi2c_gpi_xfer->dma_addr[gi2c_gpi_xfer->buf_idx];
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| *
3 errors generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
Selected by [y]:
- TI_K3_M4_REMOTEPROC [=y] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
vim +562 drivers/i2c/busses/i2c-qcom-geni.c
532
533 /**
534 * gpi_i2c_multi_desc_unmap() - unmaps the buffers post multi message TX transfers
535 * @dev: pointer to the corresponding dev node
536 * @gi2c: i2c dev handle
537 * @msgs: i2c messages array
538 * @peripheral: pointer to the gpi_i2c_config
539 */
540 static void gpi_i2c_multi_desc_unmap(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[],
541 struct gpi_i2c_config *peripheral)
542 {
543 u32 msg_xfer_cnt, wr_idx = 0;
544 struct gpi_multi_xfer *tx_multi_xfer = &peripheral->multi_xfer;
545
546 /*
547 * In error case, need to unmap all messages based on the msg_idx_cnt.
548 * Non-error case unmap all the processed messages.
549 */
550 if (gi2c->err)
551 msg_xfer_cnt = tx_multi_xfer->msg_idx_cnt;
552 else
553 msg_xfer_cnt = tx_multi_xfer->irq_cnt * NUM_MSGS_PER_IRQ;
554
555 /* Unmap the processed DMA buffers based on the received interrupt count */
556 for (; tx_multi_xfer->unmap_msg_cnt < msg_xfer_cnt; tx_multi_xfer->unmap_msg_cnt++) {
557 if (tx_multi_xfer->unmap_msg_cnt == gi2c->num_msgs)
558 break;
559 wr_idx = tx_multi_xfer->unmap_msg_cnt % QCOM_GPI_MAX_NUM_MSGS;
560 geni_i2c_gpi_unmap(gi2c, &msgs[tx_multi_xfer->unmap_msg_cnt],
561 tx_multi_xfer->dma_buf[wr_idx],
> 562 tx_multi_xfer->dma_addr[wr_idx], NULL, NULL);
563 tx_multi_xfer->freed_msg_cnt++;
564 }
565 }
566
567 static int geni_i2c_gpi(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], int cur_msg_idx,
568 struct dma_slave_config *config, dma_addr_t *dma_addr_p,
569 void **buf, unsigned int op, struct dma_chan *dma_chan)
570 {
571 struct gpi_i2c_config *peripheral;
572 unsigned int flags;
573 void *dma_buf;
574 dma_addr_t addr;
575 enum dma_data_direction map_dirn;
576 enum dma_transfer_direction dma_dirn;
577 struct dma_async_tx_descriptor *desc;
578 int ret;
579 struct gpi_multi_xfer *gi2c_gpi_xfer;
580 dma_cookie_t cookie;
581
582 peripheral = config->peripheral_config;
583 gi2c_gpi_xfer = &peripheral->multi_xfer;
584 gi2c_gpi_xfer->msg_idx_cnt = cur_msg_idx;
585 dma_buf = gi2c_gpi_xfer->dma_buf[gi2c_gpi_xfer->buf_idx];
> 586 addr = gi2c_gpi_xfer->dma_addr[gi2c_gpi_xfer->buf_idx];
587
588 dma_buf = i2c_get_dma_safe_msg_buf(&msgs[gi2c_gpi_xfer->msg_idx_cnt], 1);
589 if (!dma_buf) {
590 gi2c->err = -ENOMEM;
591 return -ENOMEM;
592 }
593
594 if (op == I2C_WRITE)
595 map_dirn = DMA_TO_DEVICE;
596 else
597 map_dirn = DMA_FROM_DEVICE;
598
599 addr = dma_map_single(gi2c->se.dev->parent,
600 dma_buf, msgs[gi2c_gpi_xfer->msg_idx_cnt].len,
601 map_dirn);
602 if (dma_mapping_error(gi2c->se.dev->parent, addr)) {
603 i2c_put_dma_safe_msg_buf(dma_buf, &msgs[gi2c_gpi_xfer->msg_idx_cnt],
604 false);
605 gi2c->err = -ENOMEM;
606 return -ENOMEM;
607 }
608
609 if (gi2c->is_tx_multi_xfer) {
610 if (((gi2c_gpi_xfer->msg_idx_cnt + 1) % NUM_MSGS_PER_IRQ))
611 peripheral->flags |= QCOM_GPI_BLOCK_EVENT_IRQ;
612 else
613 peripheral->flags &= ~QCOM_GPI_BLOCK_EVENT_IRQ;
614
615 /* BEI bit to be cleared for last TRE */
616 if (gi2c_gpi_xfer->msg_idx_cnt == gi2c->num_msgs - 1)
617 peripheral->flags &= ~QCOM_GPI_BLOCK_EVENT_IRQ;
618 }
619
620 /* set the length as message for rx txn */
621 peripheral->rx_len = msgs[gi2c_gpi_xfer->msg_idx_cnt].len;
622 peripheral->op = op;
623
624 ret = dmaengine_slave_config(dma_chan, config);
625 if (ret) {
626 dev_err(gi2c->se.dev, "dma config error: %d for op:%d\n", ret, op);
627 goto err_config;
628 }
629
630 peripheral->set_config = 0;
631 peripheral->multi_msg = true;
632 flags = DMA_PREP_INTERRUPT | DMA_CTRL_ACK;
633
634 if (op == I2C_WRITE)
635 dma_dirn = DMA_MEM_TO_DEV;
636 else
637 dma_dirn = DMA_DEV_TO_MEM;
638
639 desc = dmaengine_prep_slave_single(dma_chan, addr,
640 msgs[gi2c_gpi_xfer->msg_idx_cnt].len,
641 dma_dirn, flags);
642 if (!desc) {
643 dev_err(gi2c->se.dev, "prep_slave_sg failed\n");
644 gi2c->err = -EIO;
645 goto err_config;
646 }
647
648 desc->callback_result = i2c_gpi_cb_result;
649 desc->callback_param = gi2c;
650
651 if (!((msgs[cur_msg_idx].flags & I2C_M_RD) && op == I2C_WRITE)) {
652 gi2c_gpi_xfer->msg_idx_cnt++;
653 gi2c_gpi_xfer->buf_idx = (cur_msg_idx + 1) % QCOM_GPI_MAX_NUM_MSGS;
654 }
655 cookie = dmaengine_submit(desc);
656 if (dma_submit_error(cookie)) {
657 dev_err(gi2c->se.dev,
658 "%s: dmaengine_submit failed (%d)\n", __func__, cookie);
659 return -EINVAL;
660 }
661
662 if (gi2c->is_tx_multi_xfer) {
663 dma_async_issue_pending(gi2c->tx_c);
664 if ((cur_msg_idx == (gi2c->num_msgs - 1)) ||
665 (gi2c_gpi_xfer->msg_idx_cnt >=
666 QCOM_GPI_MAX_NUM_MSGS + gi2c_gpi_xfer->freed_msg_cnt)) {
667 ret = gpi_multi_desc_process(gi2c->se.dev, gi2c_gpi_xfer,
668 gi2c->num_msgs, XFER_TIMEOUT,
669 &gi2c->done);
670 if (ret) {
671 dev_dbg(gi2c->se.dev,
672 "I2C multi write msg transfer timeout: %d\n",
673 ret);
674 gi2c->err = -ETIMEDOUT;
675 goto err_config;
676 }
677 }
678 } else {
679 /* Non multi descriptor message transfer */
680 *buf = dma_buf;
681 *dma_addr_p = addr;
682 }
683 return 0;
684
685 err_config:
686 dma_unmap_single(gi2c->se.dev->parent, addr,
687 msgs[cur_msg_idx].len, map_dirn);
688 i2c_put_dma_safe_msg_buf(dma_buf, &msgs[cur_msg_idx], false);
689 return ret;
690 }
691
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists