linux-kernel - Re: [PATCH 1/3] erofs: get rid of erofs_{find,insert}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0db205f7-85f7-41ec-93f7-2077ee3dfb9a@linux.alibaba.com>
Date: Fri, 18 Oct 2024 12:43:12 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Chunhai Guo <guochunhai@...o.com>,
 "linux-erofs@...ts.ozlabs.org" <linux-erofs@...ts.ozlabs.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] erofs: get rid of erofs_{find,insert}_workgroup



On 2024/10/18 12:30, Chunhai Guo wrote:
>> @@ -789,7 +798,16 @@ static int z_erofs_pcluster_begin(struct z_erofs_decompress_frontend *fe)
>>    	DBG_BUGON(fe->owned_head == Z_EROFS_PCLUSTER_NIL);
>>    
>>    	if (!(map->m_flags & EROFS_MAP_META)) {
>> -		grp = erofs_find_workgroup(sb, blknr);
>> +		while (1) {
>> +			rcu_read_lock();
>> +			grp = xa_load(&EROFS_SB(sb)->managed_pslots, blknr);
>> +			if (erofs_workgroup_get(grp)) {
> I guess here should be modified as below, please refer to
> erofs_find_workgroup().

Yeah, nice catch!  Will fix it in the next version.

Thanks,
Gao Xiang