linux-kernel - Re: [PATCH v2 net] be2net: fix potential memory leak in be

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nNOYj1KocLE==MWC4A0wziDW+9-nKkHRcuFnDzhH2Yn7w@mail.gmail.com>
Date: Fri, 18 Oct 2024 10:58:30 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Wang Hai <wanghai38@...wei.com>
Cc: ajit.khaparde@...adcom.com, horms@...nel.org, 
	sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	VenkatKumar.Duvvuru@...lex.com, zhangxiaoxu5@...wei.com, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] be2net: fix potential memory leak in be_xmit()

On Tue, Oct 15, 2024 at 8:18 PM Wang Hai <wanghai38@...wei.com> wrote:
>
> The be_xmit() returns NETDEV_TX_OK without freeing skb
> in case of be_xmit_enqueue() fails, add dev_kfree_skb_any() to fix it.
>
> Fixes: 760c295e0e8d ("be2net: Support for OS2BMC.")
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>

-- 
Regards,
Kalesh A P

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)