[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87a0854a459549a5addfd39ab94669c1@realtek.com>
Date: Fri, 18 Oct 2024 05:32:00 +0000
From: Ping-Ke Shih <pkshih@...ltek.com>
To: Mohammed Anees <pvmohammedanees2003@...il.com>,
"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Kalle Valo <kvalo@...nel.org>, kernel test robot <lkp@...el.com>
Subject: RE: [PATCH v2] wifi: rtw88: Refactor looping in rtw_phy_store_tx_power_by_rate
Mohammed Anees <pvmohammedanees2003@...il.com> wrote:
> The previous implementation included an unnecessary else
> condition paired with a continue statement. Since a check
> is already performed to determine if the band is either
> 2G or 5G, the else condition will never be triggered.
> We can remove this check.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410171143.OnFlgIwK-lkp@intel.com/
no need this Closes link because of typo of v1. I will remove this during merging.
> Signed-off-by: Mohammed Anees <pvmohammedanees2003@...il.com>
Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
> ---
> v2:
> - Changed from using a pointer approach to a simpler if-else structure for clarity.
> ---
> drivers/net/wireless/realtek/rtw88/phy.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wireless/realtek/rtw88/phy.c
> index 37ef80c9091d..8b9f8f73c14c 100644
> --- a/drivers/net/wireless/realtek/rtw88/phy.c
> +++ b/drivers/net/wireless/realtek/rtw88/phy.c
> @@ -1470,10 +1470,8 @@ static void rtw_phy_store_tx_power_by_rate(struct rtw_dev *rtwdev,
> rate = rates[i];
> if (band == PHY_BAND_2G)
> hal->tx_pwr_by_rate_offset_2g[rfpath][rate] = offset;
> - else if (band == PHY_BAND_5G)
> - hal->tx_pwr_by_rate_offset_5g[rfpath][rate] = offset;
> else
> - continue;
> + hal->tx_pwr_by_rate_offset_5g[rfpath][rate] = offset;
> }
> }
>
> --
> 2.47.0
Powered by blists - more mailing lists