linux-kernel - Re: [PATCH next] drm/amdgpu: Fix a double lock bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51a348b3-8b37-4546-9514-97d94b782d28@amd.com>
Date: Fri, 18 Oct 2024 11:58:37 +0530
From: "Lazar, Lijo" <lijo.lazar@....com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 Xinhui Pan <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Hawking Zhang <Hawking.Zhang@....com>,
 Yang Wang <kevinyang.wang@....com>, Tao Zhou <tao.zhou1@....com>,
 Vignesh Chander <Vignesh.Chander@....com>, Shiwu Zhang
 <shiwu.zhang@....com>, Feifei Xu <Feifei.Xu@....com>,
 Rajneesh Bhardwaj <rajneesh.bhardwaj@....com>,
 amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] drm/amdgpu: Fix a double lock bug



On 10/18/2024 1:10 AM, Dan Carpenter wrote:
> This was supposed to be an unlock instead of a lock.  The original
> code will lead to a deadlock.
> 
> Fixes: ee52489d1210 ("drm/amdgpu: Place NPS mode request on unload")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks, this is being taken care with a follow-up patch -

https://patchwork.freedesktop.org/patch/620162/

Thanks,
Lijo

> ---
> From static analysis, not testing.
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index fcdbcff57632..3be07bcfd117 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -1605,7 +1605,7 @@ int amdgpu_xgmi_request_nps_change(struct amdgpu_device *adev,
>  					     gmc.xgmi.head)
>  		adev->gmc.gmc_funcs->request_mem_partition_mode(tmp_adev,
>  								cur_nps_mode);
> -	mutex_lock(&hive->hive_lock);
> +	mutex_unlock(&hive->hive_lock);
>  
>  	return r;
>  }