[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZxG4TiP4tliF/bms@yilunxu-OptiPlex-7050>
Date: Fri, 18 Oct 2024 09:22:22 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: iansdannapel@...il.com, mdf@...nel.org, hao.wu@...el.com,
yilun.xu@...el.com, trix@...hat.com, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, neil.armstrong@...aro.org,
heiko.stuebner@...rry.de, rafal@...ecki.pl,
linus.walleij@...aro.org, linux-fpga@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] fpga: Add Efinix Trion & Titanium serial SPI
programming driver
> > +static int efinix_spi_apply_clk_cycles(struct efinix_spi_conf *conf)
> > +{
> > + char data[13] = {0};
> > +
> > + return spi_write(conf->spi, data, sizeof(data));
>
> Hm, aren't buffers from stack discouraged? spi-summary explicitly
> mentions this case or I am getting this wrong?
You are right. And there were already some fixes for this issue in FPGA. E.g.
https://lore.kernel.org/all/20221230092922.18822-2-i.bornyakov@metrotek.ru/
Thanks,
Yilun
Powered by blists - more mailing lists